Skip to content

fix(ci,test): fix issues with PR CI runs in focil branch - #3594

Merged
spencer-tb merged 3 commits into
ethereum:eips/amsterdam/eip-7805from
fselmo:fix/ci-for-focil-branch
Sep 17, 2026
Merged

spencer-tb merged 3 commits into
ethereum:eips/amsterdam/eip-7805from
fselmo:fix/ci-for-focil-branch

Conversation

@fselmo

@fselmo fselmo commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

Keep strict checks on inclusion lists but fix CI for the time while we are hijacking amsterdam's t8n for FOCIL work.

Related Issues or PRs

N/A.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Screenshot 2026-09-16 at 13 55 43

@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/amsterdam/eip-7805@4e4fd2e). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             eips/amsterdam/eip-7805    #3594   +/-   ##
==========================================================
  Coverage                           ?   94.43%           
==========================================================
  Files                              ?      624           
  Lines                              ?    36953           
  Branches                           ?     3329           
==========================================================
  Hits                               ?    34896           
  Misses                             ?     1454           
  Partials                           ?      603           
Flag Coverage Δ
unittests 94.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fselmo
fselmo changed the base branch from devnets/focil/0 to eips/amsterdam/eip-7805 September 16, 2026 19:43
@fselmo
fselmo force-pushed the fix/ci-for-focil-branch branch from e55695e to 340f9bd Compare September 16, 2026 19:50
@fselmo
fselmo marked this pull request as ready for review September 16, 2026 19:55
@fselmo
fselmo requested a review from gurukamath September 16, 2026 19:58
@fselmo

fselmo commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

@gurukamath I'm not really privy to all the details of the amsterdam path for bogota EIPs so I want to make sure this is an OK change. I'd like to try to get CI passing for FOCIL while we don't have a proper setup for bogota and I want to also make sure to keep this strict check on inclusion lists. I think this is a decent compromise on both of these.

I think the failing pypy run here is an OOM issue. I'm ok with this for now I suppose... but will investigate this as well if I get some more time. At least the other CI jobs are better.

@fselmo

fselmo commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Ok pypy issue fixed as well as the json loader. This was an interesting find, from a quick Claude scan:

Inclusion-list fixture variants were built for every test at every fork, and dropped only after collection, because the rule that drops them needs a fork. Collection for fill-pypy and json-loader grew from 224k to 319k items, and peak memory per process from about 1.6 GB to 2.0 GB. It showed up as a PyPy MemoryError and xdist workers dying mid-collection, not as anything about Bogota. Fixed by applying the rule when tests are generated.

@spencer-tb
spencer-tb merged commit 5b33750 into ethereum:eips/amsterdam/eip-7805 Sep 17, 2026
27 checks passed
@fselmo
fselmo deleted the fix/ci-for-focil-branch branch October 8, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants