Skip to content

fix(test-consume): skip Besu evmtool's non-JSON summary line in state-test output - #3610

Merged
danceratopz merged 1 commit into
ethereum:forks/amsterdamfrom
CPerezz:fix-besu-state-test-summary-line
Sep 17, 2026
Merged

danceratopz merged 1 commit into
ethereum:forks/amsterdamfrom
CPerezz:fix-besu-state-test-summary-line

Conversation

@CPerezz

@CPerezz CPerezz commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Description

Besu 26.8.x appends State test summary: N passed, M failed after the NDJSON results of evmtool state-test. besu.py treated it as a JSON line and raised JSONDecodeError, so every consume direct --bin=evmtool run against a current Besu reported a harness failure for fixtures Besu itself had passed.

Skip any output line that does not start with a JSON object.

Verified: uv run consume direct --bin=evmtool -m state_test against Besu 26.8.1 (JDK 25) over the fixtures of #3600 went from 100% JSONDecodeError to 23/23 passed.

Related Issues or PRs

Found while verifying #3600.

Checklist

  • Ran fast static checks: ruff + mypy clean on the changed file
  • PR title has the form <type>(<area>): <title>

Cute Animal Picture

img

… output

Besu 26.8.x appends "State test summary: N passed, M failed" after the
NDJSON results. The parser treated it as a JSON line and raised
JSONDecodeError, so every consume direct run against a current Besu
reported harness failures for fixtures Besu itself had passed.

Skip lines that do not start with a JSON object.
@CPerezz CPerezz added C-bug Category: this is a bug, deviation, or other problem A-test-client-clis Area: execution_testing.client_clis labels Sep 16, 2026
@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.44%. Comparing base (f7847b7) to head (7f7847b).
⚠️ Report is 2 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #3610   +/-   ##
================================================
  Coverage            94.44%   94.44%           
================================================
  Files                  624      624           
  Lines                36928    36928           
  Branches              3326     3326           
================================================
  Hits                 34875    34875           
  Misses                1450     1450           
  Partials               603      603           
Flag Coverage Δ
unittests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danceratopz
danceratopz merged commit 2645291 into ethereum:forks/amsterdam Sep 17, 2026
30 checks passed
@danceratopz danceratopz changed the title fix(consume): skip Besu evmtool's non-JSON summary line in state-test output fix(test-consume): skip Besu evmtool's non-JSON summary line in state-test output Sep 17, 2026
@danceratopz danceratopz added the A-test-consume Area: execution_testing.cli.pytest_commands.plugins.consume label Sep 17, 2026
@CPerezz
CPerezz deleted the fix-besu-state-test-summary-line branch September 17, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-client-clis Area: execution_testing.client_clis A-test-consume Area: execution_testing.cli.pytest_commands.plugins.consume C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants