Repository navigation
feat(specs,tests): type EIP-8250 nonce keys by their most significant byte - #3724
Draft
spencer-tb wants to merge 2 commits into
Draft
spencer-tb wants to merge 2 commits into
spencer-tb wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/bogota/eip-8250 #3724 +/- ##
=======================================================
Coverage ? 94.93%
=======================================================
Files ? 677
Lines ? 41943
Branches ? 3968
=======================================================
Hits ? 39819
Misses ? 1470
Partials ? 654
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge order: independent of #3722 and #3725, merge once ethereum/EIPs#12352 merges.
Implements ethereum/EIPs#12352 on
eips/bogota/eip-8250: a nonce key's most significant byte is its type. Keys of a reserved type are rejected at decode, and a binary key only accepts sequence zero on an unused slot and is written once. The tests re-derive the key boundaries for typed keys and cover general, binary and reserved types, including slot separation between types and binary single use within a block.Related Issues or PRs
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture