Repository navigation
refactor(test-forks,test-specs): remove the unused activation code install hook in EIP-8141 - #3735
Merged
spencer-tb merged 1 commit intoOct 8, 2026
Conversation
spencer-tb
marked this pull request as ready for review
October 7, 2026 20:18
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/bogota/eip-8141 #3735 +/- ##
=======================================================
Coverage ? 94.91%
=======================================================
Files ? 676
Lines ? 41821
Branches ? 3942
=======================================================
Hits ? 39695
Misses ? 1471
Partials ? 655
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 7, 2026
spencer-tb
changed the title
gurukamath
approved these changes
Oct 8, 2026
28 of 32 tasks
spencer-tb
merged commit Oct 8, 2026
eedcb0a
into
ethereum:eips/bogota/eip-8141
27 of 28 checks passed
gurukamath
pushed a commit
that referenced
this pull request
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge order: after ethereum/EIPs#12440.
Removes the
activation_code_installsfork hook andAlloc.with_installed_code, which #3729 kept at my request for the EIP-8250 nonce manager install. ethereum/EIPs#12440 now deploys the nonce manager with a keyless transaction like the expiry verifier, so no fork installs code at activation. The six framework files match #3729's original removal (14cf9f0), and the EIP-8141 suite fills the same 735 fixtures with identical hashes.Related Issues or PRs
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.