Repository navigation
docs(specs,tests): track the EIP-8141 frame mode set-membership wording - #3739
Merged
spencer-tb merged 1 commit intoOct 8, 2026
Merged
Conversation
EIP commit 6bc5841 replaces `assert frame.mode < 3` with a membership check against the named modes and states that an extending EIP adds its value to that set without changing how the existing values are checked. `FrameMode` already enforces this as a strict enum at decode time, so no behaviour changes. Reword its docstring to match the EIP and bump the reference spec pin to the new blob.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/bogota/eip-8141 #3739 +/- ##
=======================================================
Coverage ? 94.91%
=======================================================
Files ? 676
Lines ? 41821
Branches ? 3942
=======================================================
Hits ? 39695
Misses ? 1471
Partials ? 655
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 8, 2026
spencer-tb
approved these changes
Oct 8, 2026
spencer-tb
merged commit Oct 8, 2026
1653481
into
ethereum:eips/bogota/eip-8141
27 of 28 checks passed
2 tasks done
gurukamath
added a commit
that referenced
this pull request
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Absorbs the latest EIP-8141 text change, ethereum/EIPs@6bc5841 ("check frame modes against a set of valid values"). The EIP's static validity check
assert frame.mode < 3is nowassert frame.mode in (DEFAULT, VERIFY, SENDER), and the mode table gains a sentence stating that these are the only valid values and that an extending EIP adds its value to the set without changing how existing values are checked.No behaviour changes.
FrameModeis already a strictUintEnum, so an undefined mode is rejected by set membership at decode time, and the existingundefined_frame_mode/undefined_frame_mode_highcases intest_static_validity.pycover it. This PR:FrameModedocstring to match the new EIP wording;tests/bogota/eip8141_frame_transactions/spec.pyto the new blob (4e73f1e1…, verified current against the EIPs repo).Targets
eips/bogota/eip-8141.Related Issues or PRs
Follows #3729.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.