Repository navigation
fix(test-client-clis): map ethrex's too-wide EIP-8250 nonce fields to TYPE_6_INVALID_FRAME_FORMAT - #3762
Merged
danceratopz merged 2 commits intoOct 10, 2026
Conversation
…_6_INVALID_FRAME_FORMAT ethrex rejects a frame transaction field too wide for its type while decoding, and the ethrex mapper labels the frames and signatures cases TYPE_6_INVALID_FRAME_FORMAT. EIP-8250 adds two more such fields, nonce_keys and nonce_seq, whose decode errors only matched the generic RLP_STRUCTURES_ENCODING pattern. test_static_validity's key_beyond_width and seq_beyond_width cases, which expect TYPE_6_INVALID_FRAME_FORMAT, therefore failed in hive's consume-engine run for ethrex although ethrex rejects the payload as INVALID. The pattern now covers all four fields. The new mapper test pins ethrex's verbatim messages, including the two from that run, and checks the label does not reach a legacy transaction's nonce field.
The test restated the mapper's regex against copies of ethrex's messages, so it could not catch the failure that matters, ethrex rewording a message, and hive's consume-engine run already covers the mapping against the client itself. The fix is the mapper change alone, as for the other client mappers.
danceratopz
added
C-bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/bogota/eip-8250 #3762 +/- ##
=======================================================
Coverage ? 94.95%
=======================================================
Files ? 677
Lines ? 41940
Branches ? 3960
=======================================================
Hits ? 39825
Misses ? 1464
Partials ? 651
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danceratopz
changed the title
30 of 32 tasks
14 of 16 tasks
spencer-tb
pushed a commit
that referenced
this pull request
Oct 13, 2026
… TYPE_6_INVALID_FRAME_FORMAT (#3762)
gurukamath
pushed a commit
that referenced
this pull request
Oct 13, 2026
… TYPE_6_INVALID_FRAME_FORMAT (#3762)
gurukamath
pushed a commit
that referenced
this pull request
Oct 13, 2026
… TYPE_6_INVALID_FRAME_FORMAT (#3762)
gurukamath
pushed a commit
that referenced
this pull request
Oct 15, 2026
… TYPE_6_INVALID_FRAME_FORMAT (#3762)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ethrex rejects a frame transaction field too wide for its type while decoding, and the ethrex mapper already labels the
framesandsignaturescasesTYPE_6_INVALID_FRAME_FORMAT. EIP-8250 adds two more such fields,nonce_keysandnonce_seq, whose decode errors only matched the genericRLP_STRUCTURES_ENCODINGpattern. Sotest_static_validity'skey_beyond_widthandseq_beyond_widthcases, which expectTYPE_6_INVALID_FRAME_FORMAT, are the two failures in hive's frameseels/consume-enginerun for ethrex, although ethrex returns INVALID for both payloads:got: "[BlockException.RLP_STRUCTURES_ENCODING] Error decoding field 'nonce_keys' of type alloc::vec::Vec<primitive_types::U256>: InvalidLength" expected: "TransactionException.TYPE_6_INVALID_FRAME_FORMAT"The pattern now covers all four fields. Checked locally by running the mapper on the two messages from that run, verbatim: both now include
TYPE_6_INVALID_FRAME_FORMAT, theframesandsignaturesdecode errors still do, and a legacy transaction'snoncedecode error still maps only toRLP_STRUCTURES_ENCODING.Hive builds the consume simulator from
devnets/frames/1, so the hive failures clear once this reaches that branch. The commit also applies cleanly there.Related Issues or PRs
frames-devnet@v1.0.0#3727.Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture