Repository navigation
feat(tests): pin TXPARAM's max cost with the EIP-8250 key cost - #3803
Merged
fselmo merged 4 commits intoOct 13, 2026
Merged
Conversation
The existing TXPARAM max cost test only checks that the value equals how much the payer's balance dropped. A client that leaves the key cost out of both would still pass. This test pins the exact max cost for a transaction with no nonce keys and for one with the maximum key set.
The EIP-8141 max cost test now covers the legacy key set and the maximum key set, pinning both the payer's escrow and the exact max cost, so the separate EIP-8250 test that repeated its legacy case goes.
fselmo
changed the title
fselmo
added
C-feat
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/bogota/eip-8250 #3803 +/- ##
=======================================================
Coverage ? 95.01%
=======================================================
Files ? 678
Lines ? 41930
Branches ? 3933
=======================================================
Hits ? 39841
Misses ? 1453
Partials ? 636
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gurukamath
changed the title
gurukamath
reviewed
Oct 13, 2026
EIP-8141's tests should not import EIP-8250, which builds on it. test_txparam_max_cost goes back to one case, now an exact pin of the legacy max cost, and the maximum key set's pin sits next to the payer max cost test. Both pass nonce_seq to the calculator explicitly.
Contributor
Author
|
@gurukamath ready for another pass. Thanks for the review 👍🏼 |
Contributor
Author
|
hmm thinking about this more, I guess that 8141 test update should go to |
Contributor
|
Agree, I'd move the introspection pin test to its own PR on |
Contributor
|
We could just use the devnet branches maybe... going forward... |
Contributor
Author
|
It's tough to do cross-eip stuff while everything is isolated 🫠 |
fselmo
changed the title
This PR targets the EIP-8250 branch, so it only adds the keyed max cost pin to the EIP-8250 suite.
Contributor
Author
dropped 👍🏼 |
spencer-tb
approved these changes
Oct 13, 2026
gurukamath
pushed a commit
that referenced
this pull request
Oct 13, 2026
* feat(tests): pin TXPARAM's max cost with the EIP-8250 key cost The existing TXPARAM max cost test only checks that the value equals how much the payer's balance dropped. A client that leaves the key cost out of both would still pass. This test pins the exact max cost for a transaction with no nonce keys and for one with the maximum key set. * refactor(tests): fold the keyed max cost case into test_txparam_max_cost The EIP-8141 max cost test now covers the legacy key set and the maximum key set, pinning both the payer's escrow and the exact max cost, so the separate EIP-8250 test that repeated its legacy case goes. * refactor(tests): move the keyed max cost pin to the EIP-8250 suite EIP-8141's tests should not import EIP-8250, which builds on it. test_txparam_max_cost goes back to one case, now an exact pin of the legacy max cost, and the maximum key set's pin sits next to the payer max cost test. Both pass nonce_seq to the calculator explicitly. * refactor(tests): leave the EIP-8141 max cost test unchanged This PR targets the EIP-8250 branch, so it only adds the keyed max cost pin to the EIP-8250 suite.
16 tasks done
gurukamath
pushed a commit
that referenced
this pull request
Oct 15, 2026
* feat(tests): pin TXPARAM's max cost with the EIP-8250 key cost The existing TXPARAM max cost test only checks that the value equals how much the payer's balance dropped. A client that leaves the key cost out of both would still pass. This test pins the exact max cost for a transaction with no nonce keys and for one with the maximum key set. * refactor(tests): fold the keyed max cost case into test_txparam_max_cost The EIP-8141 max cost test now covers the legacy key set and the maximum key set, pinning both the payer's escrow and the exact max cost, so the separate EIP-8250 test that repeated its legacy case goes. * refactor(tests): move the keyed max cost pin to the EIP-8250 suite EIP-8141's tests should not import EIP-8250, which builds on it. test_txparam_max_cost goes back to one case, now an exact pin of the legacy max cost, and the maximum key set's pin sits next to the payer max cost test. Both pass nonce_seq to the calculator explicitly. * refactor(tests): leave the EIP-8141 max cost test unchanged This PR targets the EIP-8250 branch, so it only adds the keyed max cost pin to the EIP-8250 suite.
gurukamath
pushed a commit
that referenced
this pull request
Oct 21, 2026
* feat(tests): pin TXPARAM's max cost with the EIP-8250 key cost The existing TXPARAM max cost test only checks that the value equals how much the payer's balance dropped. A client that leaves the key cost out of both would still pass. This test pins the exact max cost for a transaction with no nonce keys and for one with the maximum key set. * refactor(tests): fold the keyed max cost case into test_txparam_max_cost The EIP-8141 max cost test now covers the legacy key set and the maximum key set, pinning both the payer's escrow and the exact max cost, so the separate EIP-8250 test that repeated its legacy case goes. * refactor(tests): move the keyed max cost pin to the EIP-8250 suite EIP-8141's tests should not import EIP-8250, which builds on it. test_txparam_max_cost goes back to one case, now an exact pin of the legacy max cost, and the maximum key set's pin sits next to the payer max cost test. Both pass nonce_seq to the calculator explicitly. * refactor(tests): leave the EIP-8141 max cost test unchanged This PR targets the EIP-8250 branch, so it only adds the keyed max cost pin to the EIP-8250 suite.
gurukamath
pushed a commit
that referenced
this pull request
Oct 21, 2026
* feat(tests): pin TXPARAM's max cost with the EIP-8250 key cost The existing TXPARAM max cost test only checks that the value equals how much the payer's balance dropped. A client that leaves the key cost out of both would still pass. This test pins the exact max cost for a transaction with no nonce keys and for one with the maximum key set. * refactor(tests): fold the keyed max cost case into test_txparam_max_cost The EIP-8141 max cost test now covers the legacy key set and the maximum key set, pinning both the payer's escrow and the exact max cost, so the separate EIP-8250 test that repeated its legacy case goes. * refactor(tests): move the keyed max cost pin to the EIP-8250 suite EIP-8141's tests should not import EIP-8250, which builds on it. test_txparam_max_cost goes back to one case, now an exact pin of the legacy max cost, and the maximum key set's pin sits next to the payer max cost test. Both pass nonce_seq to the calculator explicitly. * refactor(tests): leave the EIP-8141 max cost test unchanged This PR targets the EIP-8250 branch, so it only adds the keyed max cost pin to the EIP-8250 suite.
gurukamath
pushed a commit
that referenced
this pull request
Oct 21, 2026
* feat(tests): pin TXPARAM's max cost with the EIP-8250 key cost The existing TXPARAM max cost test only checks that the value equals how much the payer's balance dropped. A client that leaves the key cost out of both would still pass. This test pins the exact max cost for a transaction with no nonce keys and for one with the maximum key set. * refactor(tests): fold the keyed max cost case into test_txparam_max_cost The EIP-8141 max cost test now covers the legacy key set and the maximum key set, pinning both the payer's escrow and the exact max cost, so the separate EIP-8250 test that repeated its legacy case goes. * refactor(tests): move the keyed max cost pin to the EIP-8250 suite EIP-8141's tests should not import EIP-8250, which builds on it. test_txparam_max_cost goes back to one case, now an exact pin of the legacy max cost, and the maximum key set's pin sits next to the payer max cost test. Both pass nonce_seq to the calculator explicitly. * refactor(tests): leave the EIP-8141 max cost test unchanged This PR targets the EIP-8250 branch, so it only adds the keyed max cost pin to the EIP-8250 suite.
spencer-tb
pushed a commit
to spencer-tb/execution-specs
that referenced
this pull request
Oct 23, 2026
…eum#3803) * feat(tests): pin TXPARAM's max cost with the EIP-8250 key cost The existing TXPARAM max cost test only checks that the value equals how much the payer's balance dropped. A client that leaves the key cost out of both would still pass. This test pins the exact max cost for a transaction with no nonce keys and for one with the maximum key set. * refactor(tests): fold the keyed max cost case into test_txparam_max_cost The EIP-8141 max cost test now covers the legacy key set and the maximum key set, pinning both the payer's escrow and the exact max cost, so the separate EIP-8250 test that repeated its legacy case goes. * refactor(tests): move the keyed max cost pin to the EIP-8250 suite EIP-8141's tests should not import EIP-8250, which builds on it. test_txparam_max_cost goes back to one case, now an exact pin of the legacy max cost, and the maximum key set's pin sits next to the payer max cost test. Both pass nonce_seq to the calculator explicitly. * refactor(tests): leave the EIP-8141 max cost test unchanged This PR targets the EIP-8250 branch, so it only adds the keyed max cost pin to the EIP-8250 suite.
spencer-tb
pushed a commit
that referenced
this pull request
Oct 23, 2026
* feat(tests): pin TXPARAM's max cost with the EIP-8250 key cost The existing TXPARAM max cost test only checks that the value equals how much the payer's balance dropped. A client that leaves the key cost out of both would still pass. This test pins the exact max cost for a transaction with no nonce keys and for one with the maximum key set. * refactor(tests): fold the keyed max cost case into test_txparam_max_cost The EIP-8141 max cost test now covers the legacy key set and the maximum key set, pinning both the payer's escrow and the exact max cost, so the separate EIP-8250 test that repeated its legacy case goes. * refactor(tests): move the keyed max cost pin to the EIP-8250 suite EIP-8141's tests should not import EIP-8250, which builds on it. test_txparam_max_cost goes back to one case, now an exact pin of the legacy max cost, and the maximum key set's pin sits next to the payer max cost test. Both pass nonce_seq to the calculator explicitly. * refactor(tests): leave the EIP-8141 max cost test unchanged This PR targets the EIP-8250 branch, so it only adds the keyed max cost pin to the EIP-8250 suite.
gurukamath
pushed a commit
that referenced
this pull request
Oct 27, 2026
* feat(tests): pin TXPARAM's max cost with the EIP-8250 key cost The existing TXPARAM max cost test only checks that the value equals how much the payer's balance dropped. A client that leaves the key cost out of both would still pass. This test pins the exact max cost for a transaction with no nonce keys and for one with the maximum key set. * refactor(tests): fold the keyed max cost case into test_txparam_max_cost The EIP-8141 max cost test now covers the legacy key set and the maximum key set, pinning both the payer's escrow and the exact max cost, so the separate EIP-8250 test that repeated its legacy case goes. * refactor(tests): move the keyed max cost pin to the EIP-8250 suite EIP-8141's tests should not import EIP-8250, which builds on it. test_txparam_max_cost goes back to one case, now an exact pin of the legacy max cost, and the maximum key set's pin sits next to the payer max cost test. Both pass nonce_seq to the calculator explicitly. * refactor(tests): leave the EIP-8141 max cost test unchanged This PR targets the EIP-8250 branch, so it only adds the keyed max cost pin to the EIP-8250 suite.
spencer-tb
pushed a commit
that referenced
this pull request
Oct 27, 2026
* feat(tests): pin TXPARAM's max cost with the EIP-8250 key cost The existing TXPARAM max cost test only checks that the value equals how much the payer's balance dropped. A client that leaves the key cost out of both would still pass. This test pins the exact max cost for a transaction with no nonce keys and for one with the maximum key set. * refactor(tests): fold the keyed max cost case into test_txparam_max_cost The EIP-8141 max cost test now covers the legacy key set and the maximum key set, pinning both the payer's escrow and the exact max cost, so the separate EIP-8250 test that repeated its legacy case goes. * refactor(tests): move the keyed max cost pin to the EIP-8250 suite EIP-8141's tests should not import EIP-8250, which builds on it. test_txparam_max_cost goes back to one case, now an exact pin of the legacy max cost, and the maximum key set's pin sits next to the payer max cost test. Both pass nonce_seq to the calculator explicitly. * refactor(tests): leave the EIP-8141 max cost test unchanged This PR targets the EIP-8250 branch, so it only adds the keyed max cost pin to the EIP-8250 suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_txparam_max_costonly checked thatTXPARAM's max cost matches the payer's balance drop, which still holds if a client leaves the EIP-8250 keyed nonce access cost out of both. I parametrized it over the legacy key set and the maximum key set, and it now pins the exact max cost (the fork's maximum gas for the transaction times the fee cap) as well as the balance drop.The legacy case is the same transaction as before, just the contract changed... now it stores / pins both values instead of one.
Related Issues or PRs
Follows #3756 and #3775 (tracker #3773).
Checklist
just static<type>(<area>): <description>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture
🐼