yash/refactor/natspec#448
Open
0xpanicError wants to merge 6 commits into
Open
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Changes are mostly comments and reordering; the only behavioral footgun is WeETH’s renamed ZeroAddress error and constructor struct moves affecting new deployments and error decoders, not live upgrade logic.
Overview
This PR is a documentation and layout refactor across core staking contracts (
EETH,WeETH,LiquidityPool),DepositAdapter, andLiquifier: it adds NatSpec (@notice/@param/@dev), groups code under section banners (constructor, mint/burn, pausing, getters, modifiers), and reorders some members for readability (e.g.permitand EIP-712 helpers inEETH,receive()placement inLiquidityPool).Shared types move into interfaces:
ConstructorAddressesandSourceOfFundsland onILiquidityPool;Liquifierand newIDepositAdapterget their ownConstructorAddresses/SourceOfFunds, andDepositAdapternow implementsIDepositAdapterwith a single struct constructor instead of many address parameters.Small non-doc deltas:
WeETHrenamesAddressZerotoZeroAddress(same checks, different custom error);Liquifierreplaces a local_minwithMath.min. No intentional changes to mint/burn, rate limits, pause gates, or withdrawal guard logic are evident in the diff.Reviewed by Cursor Bugbot for commit 189f19e. Bugbot is set up for automated code reviews on this repo. Configure here.