fix(joiner): add bounds checking on leaf reads#5524
Merged
Conversation
janos
requested review from
acud,
akrem-chabchoub,
gacevicljubisa,
martinconic and
sbackend123
gacevicljubisa
approved these changes
Jul 6, 2026
martinconic
approved these changes
Jul 7, 2026
| } | ||
|
|
||
| // Guard against slicing out-of-bounds if the computed end offset is invalid. | ||
| if dataOffsetEnd < dataOffsetStart || dataOffsetEnd > int64(len(data)) { |
Contributor
There was a problem hiding this comment.
You can also use here dataLen like above, right?
Member
Author
There was a problem hiding this comment.
Yes, that is right, thanks.
akrem-chabchoub
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR fixes a panic (crash) and an infinite loop (hang/timeout) when reading malformed or corrupted trees in the joiner.
When the joiner processes a malformed tree where intermediate or root chunks advertise spans larger than the actual data present in their children it hangs in io.Copy as it always returns (0, nil), or panics when the data is requested by the look-ahead reader langos as the io.SeekEnd on joiner's Seek() reports longer data.
Tests are added for fix verification. The real world chunks and initial testing was provided by @acud, thanks.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure