fix(db): keep migration versions unique - #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause\n\nProduction Corpus reached Cloud SQL after the deploy-repo egress fix, then failed at startup because the repository contains two migrations with version prefix 0010. SQLx stores that prefix as the primary key in the _sqlx_migrations table; the live database has version 10 (receipts and cleanup) applied, and the second 0010 (Merlin observations) caused the duplicate-key failure.\n\n## Fix\n\n- Rename 0010_merlin_observations.sql to 0012_merlin_observations.sql, preserving the already-applied version-10 checksum and allowing version 11 to apply before Merlin version 12.\n- Add a unit regression test that rejects duplicate numeric migration prefixes.\n\n## Verification\n\n- cargo fmt --all -- --check\n- cargo test -p corpus-core --lib (96 passed)\n- cargo test -p corpus-server --no-run\n- Live DB migration state inspected read-only; no values or secrets exposed.