fix(api): preserve managed-home provider preference - #335
Merged
Conversation
haasonsaas
enabled auto-merge (squash)
August 6, 2026 17:17
haasonsaas
disabled auto-merge
August 6, 2026 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Platform persistent-computer requests send
workspace_mode=persistentandprovider_preference=cloudflaretoPOST /v1/homes/{home_id}/sandboxes. The managed-home wrapper replaced that preference withany, so the Cloudflare worker could not claim the job after sandboxwich#334 tightened provider matching.This change carries the request's explicit provider preference into the managed-home provision spec. An omitted preference still defaults to
any.Regression
The HTTP contract test registers Kubernetes and Cloudflare workers, creates a persistent managed-home sandbox with
provider_preference=cloudflare, and verifies:provisionSpec.provider_preferenceremainscloudflare.Tests
cargo test -p sandboxwich-api --test http_contract homes::cargo test -p sandboxwich-api provider_preferencecargo test -p sandboxwich-api --test http_contract sandboxes::cargo fmt --all -- --check