Skip to content

ci: align the fallback review prompt with the convergence policy #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evansenter merged 1 commit into from
Oct 17, 2026
Merged

ci: align the fallback review prompt with the convergence policy #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/claude-code-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ jobs:
REPO: ${{ github.repository }}
PR_NUMBER: ${{ github.event.pull_request.number }}

${{ steps.prompt.outputs.use_file == 'true' && 'First, read the review instructions from /tmp/review-prompt.md using your Read tool. Then follow those instructions to review this PR.' || 'Review this PR for code quality, bugs, security issues, and adherence to project conventions (check CLAUDE.md). Check for previous "Feedback Addressed" comments to avoid re-raising resolved issues. Be strict: REQUEST_CHANGES for any issues found, only APPROVE if genuinely ready to merge. Submit your review using gh api repos/$REPO/pulls/$PR_NUMBER/reviews with inline comments on specific files/lines and event set to APPROVE or REQUEST_CHANGES. Start the review body with: > **Prompt:** Fallback (centralized prompt fetch failed)' }}
${{ steps.prompt.outputs.use_file == 'true' && 'First, read the review instructions from /tmp/review-prompt.md using your Read tool. Then follow those instructions to review this PR.' || 'Review this PR for code quality, bugs, security issues, and adherence to project conventions (check CLAUDE.md). Check for previous "Feedback Addressed" comments to avoid re-raising resolved issues. REQUEST_CHANGES only for Critical issues or for Important issues that name a concrete failure scenario (inputs or state leading to a wrong result); otherwise APPROVE and post the rest as inline Suggestions. Submit your review using gh api repos/$REPO/pulls/$PR_NUMBER/reviews with inline comments on specific files/lines and event set to APPROVE or REQUEST_CHANGES. Start the review body with: > **Prompt:** Fallback (centralized prompt fetch failed)' }}

Use the REPO and PR_NUMBER variables provided above.
# Tools required by the centralized prompt (see contrib/prompts/claude-review.md).
# Model: opus (Claude Opus 5) — matches the interactive Claude Code default in
# home/.claude/settings.json, at roughly half Fable's price. Bump to --model
# fable if review depth on a given repo turns out to need it.
# Model: the opus alias — matches the interactive Claude Code default in
# home/.claude/settings.json, at well under half Fable's per-token price.
# Bump to --model fable if review depth on a given repo turns out to need it.
claude_args: '--model opus --allowed-tools "Read,Bash(gh pr view:*),Bash(gh pr diff:*),Bash(gh pr comment:*),Bash(gh pr review:*),Bash(gh issue view:*),Bash(gh issue comment:*),Bash(gh api:*)"'
2 changes: 1 addition & 1 deletion .github/workflows/claude.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
additional_permissions: |
actions: read
# Deliberately unpinned: @claude responses track the claude-code-action
# default model (Sonnet 5 as of v2.1.197), matching every other repo.
# default model, matching every other repo.
# Only claude-code-review.yml pins a model, because review depth is the
# thing worth paying for. Ask for a model by name in the @claude comment
# when a specific task needs one.
Loading