feat: dump requests the capped cost stage left unproven - #155
Merged
Merged
Conversation
With the cost stage capped nothing exhausts the time limit any more, so the slow request dump stopped filling. A request now also lands in it when the cost stage gap is above one currency unit, and the dump line carries that gap, so the replay corpus holds exactly the requests where a longer clock might have bought money.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #154. The cost stage cap keeps requests short of the time limit, so
OPTIMIZER_DUMP_SLOW_REQUESTSstopped collecting anything, and the first 45 minutes of the gap log showed the requests worth replaying are the ones the cap left a gap on.cost_stage_gapis aboveDUMP_GAP, one currency unit.🤖 Generated with Claude Code