strip any extension from imported dll names - #23
Merged
Merged
Conversation
WINSPOOL.DRV imports produced a module path with a dot in it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Owner
|
According to an LLM (heh), it seems like the Windows behavior is to strip the extension in any case, because there are other file types that have similar behavior, like .ocr for screensaver modules. |
evmar
reviewed
Sep 16, 2026
| // (.dll, or .drv for winspool). | ||
| let name = name | ||
| .rsplit_once('.') | ||
| .map_or(name.as_str(), |(stem, _)| stem); |
Owner
There was a problem hiding this comment.
I wonder if .with_extension("") would be better, not that I really care
https://doc.rust-lang.org/std/path/struct.Path.html#method.with_extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you rather I add another check specifically for
.drvinstead I'd be happy to do that instead!From Claude Fable 5.1 (high):