Skip to content

feat(rpc): reconstruct attester commits deterministically (Part 3)#396

Draft
randygrok wants to merge 1 commit intosplit/02-vote-verificationfrom
split/03-rpc-commit
Draft

feat(rpc): reconstruct attester commits deterministically (Part 3)#396
randygrok wants to merge 1 commit intosplit/02-vote-verificationfrom
split/03-rpc-commit

Conversation

@randygrok
Copy link
Copy Markdown
Contributor

Summary

This is Part 3 of the prod-readiness split, stacked on #395.

Changes:

  • Add the AttesterSet query endpoint for the fixed ordered attester set.
  • Reconstruct attester-mode commits using the full set, with absent entries for non-signers.
  • Gate reconstructed commits on strict quorum before returning them.
  • Make /validators return the same full attester set used by /commit.
  • Add tests for deterministic commit reconstruction and validator ordering.

Validation

  • go test ./pkg/adapter ./pkg/rpc/core ./modules/network/...

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e4af8c64-6d15-466f-9fae-dcffb62dff5b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch split/03-rpc-commit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant