Skip to content

chore: fix some minor issues in comments #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 1 commit into from
May 2, 2026
+2 −2
Merged

chore: fix some minor issues in comments #3304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion block/internal/cache/generic_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (c *Cache) setSeenBatch(hashes []string, height uint64) {
return
}

// currently not used, but there for compleness against setSeen
// currently not used, but there for completeness against setSeen
for _, h := range hashes {
if existing, ok := c.hashByHeight[height]; ok && existing == h {
c.hashes[existing] = true
Expand Down
2 changes: 1 addition & 1 deletion block/internal/cache/generic_cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ func TestHeightPlaceholderKey(t *testing.T) {
// TestCache_NoPlaceholderLeakAfterRefire verifies that when the DA retriever
// re-fires setDAIncluded with the real content hash after a restart, the
// snapshot placeholder that RestoreFromStore installed is evicted from
// daIncluded. Without the eviction in setDAIncluded, every restart cycle
// daIncluded. Without the eviction in setDAIncluded, every restart cycle
// would leak one orphaned placeholder key per in-flight block.
func TestCache_NoPlaceholderLeakAfterRefire(t *testing.T) {
st := testMemStore(t)
Expand Down