Skip to content

Security/812 switch GitHub actions to shas#813

Draft
ArBridgeman wants to merge 10 commits intomainfrom
security/812_switch_github_actions_to_shas
Draft

Security/812 switch GitHub actions to shas#813
ArBridgeman wants to merge 10 commits intomainfrom
security/812_switch_github_actions_to_shas

Conversation

@ArBridgeman
Copy link
Copy Markdown
Collaborator

closes #812

Checklist

Note: If any of the items in the checklist are not relevant to your PR, just check the box.

For any Pull Request

Is the following correct:

  • the title of the Pull Request?
  • the title of the corresponding issue?
  • there are no other open Pull Requests for the same update/change?
  • that the issue which this Pull Request fixes ("Fixes...") is mentioned?

When Changes Were Made

Did you:

  • update the changelog?
  • update the cookiecutter-template?
  • update the implementation?
  • check coverage and add tests: unit tests and, if relevant, integration tests?
  • update the User Guide & other documentation?
  • resolve any failing CI criteria (incl. Sonar quality gate)?

When Preparing a Release

Have you:

  • thought about version number (major, minor, patch)?
  • checked Exasol packages for updates and resolved open vulnerabilities, if easily possible?

@sonarqubecloud
Copy link
Copy Markdown

Comment thread test/unit/config_test.py
valid_version_string("$.2.3")


class TestGitHubActionSHAs:
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also in this PR manually update the actions and workflow that the PTB does not control?

- name: Check out Repository
id: check-out-repository
uses: actions/checkout@v6
uses: "actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also augment to put out the version as a comment.
zimor verifies if it's correct or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch GitHub actions to pins from BaseConfig

1 participant