Skip to content

Fix regression batch processing - #2497

Open
niemyjski wants to merge 10 commits into
mainfrom
feature/darren-feedback-followups
Open

Fix regression batch processing#2497
niemyjski wants to merge 10 commits into
mainfrom
feature/darren-feedback-followups

Conversation

@niemyjski

@niemyjski niemyjski commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

  • Continue fixed-stack regression processing when an earlier stack has no regression candidate.
  • Cover the multi-stack batch path through the existing integration test fixture.
  • Remove the proposed saved-view prompt and broad 5xx status redirect changes from this PR.

User impact

A fixed stack with no regression candidate no longer prevents a later fixed stack in the same batch from being marked as regressed. Existing API status-page routing remains unchanged: only status 0, 408, and 503 trigger recovery.

Verification

  • Exact head: d185d57b08eac2e4831ab06a1762bb7ee7bcc5a9
  • Base: origin/main at 24d6ad72a6659eec918c4655b531c099208912da; branch is 0 commits behind
  • dotnet build tests/Exceptionless.Tests/Exceptionless.Tests.csproj --no-restore — passed with 0 warnings and 0 errors
  • Focused integration test compiled locally; local execution was blocked before startup because Docker was not running
  • Hosted test-api executed the integration suite successfully in 5m55s
  • Hosted test-client, test-e2e, docker-build, version, and CLA checks passed on the exact head
  • git diff --check origin/main...HEAD — passed

Review

  • Thermo-nuclear maintainability review against origin/main...HEAD — no blocking findings
  • Standards review — 0 findings
  • Spec review — 0 findings
  • All review threads are answered and resolved
  • Final diff: 2 files, +41/-1; no modal, CSS, saved-view, or service-status behavior changes

Notes

The broad 5xx redirect was originally inferred from the reported intermittent site-wide 500 errors. That inference was incorrect for client routing: ordinary API 500 responses must not redirect to the status page, so the change was fully backed out.

@niemyjski
niemyjski force-pushed the feature/darren-feedback-followups branch from 6ab0b59 to fd749a8 Compare August 19, 2026 03:29
@niemyjski
niemyjski marked this pull request as ready for review August 19, 2026 03:31

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd749a81b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24fe0e5c22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56d86e1237

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f27306f4c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19db9598aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@niemyjski niemyjski changed the title Fix saved view navigation and feedback regressions Fix regression processing and 5xx recovery Aug 19, 2026
Comment thread tests/Exceptionless.Tests/Pipeline/CheckForRegressionActionTests.cs Outdated
Comment thread tests/Exceptionless.Tests/Pipeline/CheckForRegressionActionTests.cs Outdated
Comment thread tests/Exceptionless.Tests/Pipeline/CheckForRegressionActionTests.cs Outdated
Comment thread tests/Exceptionless.Tests/Pipeline/CheckForRegressionActionTests.cs Outdated
Comment thread tests/Exceptionless.Tests/Pipeline/CheckForRegressionActionTests.cs Outdated
Comment thread tests/Exceptionless.Tests/Pipeline/CheckForRegressionActionTests.cs Outdated
@niemyjski niemyjski changed the title Fix regression processing and 5xx recovery Fix regression batch processing Aug 20, 2026

@niemyjski niemyjski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all current review feedback in d185d57. The PR now contains only the regression batch continue fix and its canonical integration coverage; the broad 5xx redirect and saved-view prompt changes are fully removed.

Comment thread tests/Exceptionless.Tests/Pipeline/CheckForRegressionActionTests.cs Outdated
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.Insulation 37% 35% 286
Exceptionless.Core 75% 67% 10184
Exceptionless.Web 85% 69% 7903
Exceptionless.AppHost 38% 41% 147
Summary 78% (25167 / 32154) 67% (11823 / 17554) 18520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant