Skip to content

exercices/concept/secrets: Add link to the integer division function in the instructions - #1650

Closed
grgmiranda wants to merge 1 commit into
exercism:mainfrom
grgmiranda:patch-2
Closed

exercices/concept/secrets: Add link to the integer division function in the instructions#1650
grgmiranda wants to merge 1 commit into
exercism:mainfrom
grgmiranda:patch-2

Conversation

@grgmiranda

Copy link
Copy Markdown

Just a little tweak, making more explicit what "integer function" refers to.

It's already linked in the HINTS, but not in the instructions.

Just a little tweak, making more explicit what "integer function" refers to.
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Concept exercise changed

    • 🌲 Do prerequisites and practices in config.json need to be updated?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?

Automated comment created by PR Commenter 🤖.

@angelikatyborska

Copy link
Copy Markdown
Member

Hi! Thank you for the PR. I am afraid I need to reject it. Exercise introductions and instructions do not contain links on purpose. Exercise introductions and instructions should be concise and explain enough knowledge to be able to solve the exercise, but they shouldn't overexplain. Hints are meant to provide links to specific functions necessary to solve the exercise.

@grgmiranda

Copy link
Copy Markdown
Author

Oh, ok, sorry that I haven't notice this before, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants