Skip to content

chore: remove remaining import scratch from data/ - #625

Merged
jeffreylouden merged 1 commit into
mainfrom
chore/remove-remaining-import-scratch
Aug 15, 2026
Merged

chore: remove remaining import scratch from data/#625
jeffreylouden merged 1 commit into
mainfrom
chore/remove-remaining-import-scratch

Conversation

@jeffreylouden

@jeffreylouden jeffreylouden commented Aug 15, 2026

Copy link
Copy Markdown
Member

PR #426 added a .gitignore whitelist so data/ tracks only the five canonical collections, and removed the data/ddmf/merge-pr-body.md leak. Five more slipped past it.

Why the guard missed them

All five landed after #426. PRs #409, #410, #411, #412 and #414 were branched before the guard and merged after it, so their already-staged scratch files were unaffected by the new ignore rule — gitignore has no say over what's already staged.

2026-06-19T15:41  464a9df8  guard lands (#426)
2026-06-19T16:32  ed8b265b  algorithmix      (#409)  ← branched pre-guard
2026-06-19T18:25  25446169  aom              (#411)
2026-06-19T19:52  1395f127  auburn-sounds    (#410)
2026-06-19T19:53  81efb1de  aly-james-lab    (#412)
2026-06-19T20:04  7a2545b2  black-salt-audio (#414)

Changes

Removes the five stragglers:

  • data/algorithmix/merge-pr-body.md
  • data/aly-james-lab/merge-pr-body.md
  • data/aom/merge-pr-body.md
  • data/auburn-sounds/merge-pr-body.md
  • data/black-salt-audio/merge-pr-body.md

These are gh pr create --body-file inputs, not catalog data.

Verification

Note

The guard itself is holding — no scratch has been committed to data/ in the ~2 months since these five landed, and the source workflow was separately fixed to write to the racks scratch dir. This is cleanup of a closed problem, not a live leak.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed outdated merge-plan and merge-report documents for several catalog sources.
    • Removed historical conflict details, validation results, safe-add records, and audit-trail references from the repository.

PR #426 added a .gitignore whitelist so data/ tracks only the five
canonical collections, and removed the data/ddmf/merge-pr-body.md leak.
Five more slipped past it: PRs #409, #410, #411, #412 and #414 were
branched before the guard landed and merged after it, so their already-
staged scratch files were unaffected by the new ignore rule.

Remove the five stragglers:

- data/algorithmix/merge-pr-body.md
- data/aly-james-lab/merge-pr-body.md
- data/aom/merge-pr-body.md
- data/auburn-sounds/merge-pr-body.md
- data/black-salt-audio/merge-pr-body.md

These are `gh pr create --body-file` inputs, not catalog data. Nothing in
the codebase references them and they contain no YAML, so `pnpm validate`
is unchanged at 16729 entries. No changeset: the check only fires on
`^data/.*\.yaml$`, and #426 set the same precedent.

The guard itself is holding — no scratch has been committed to data/ in
the ~2 months since these five landed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b8b80ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 090844f0-e88f-42f8-bb65-9b0d18c124d9

📥 Commits

Reviewing files that changed from the base of the PR and between 033a9bd and b8b80ef.

📒 Files selected for processing (5)
  • data/algorithmix/merge-pr-body.md
  • data/aly-james-lab/merge-pr-body.md
  • data/aom/merge-pr-body.md
  • data/auburn-sounds/merge-pr-body.md
  • data/black-salt-audio/merge-pr-body.md
💤 Files with no reviewable changes (5)
  • data/aly-james-lab/merge-pr-body.md
  • data/aom/merge-pr-body.md
  • data/algorithmix/merge-pr-body.md
  • data/black-salt-audio/merge-pr-body.md
  • data/auburn-sounds/merge-pr-body.md

Walkthrough

Five vendor-specific merge-pr-body.md merge-plan documents were deleted. No exported or public entities changed.

Changes

Cohort / File(s) Summary
Deleted merge-plan documents
data/algorithmix/merge-pr-body.md, data/aly-james-lab/merge-pr-body.md, data/aom/merge-pr-body.md, data/auburn-sounds/merge-pr-body.md, data/black-salt-audio/merge-pr-body.md
Removed merge plans, conflict details, validation records, and audit-trail references.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b8b80

This change removes five stray scratch files from the data directories without altering catalog data or runtime behavior; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the deletion of the remaining import scratch files from the data directory.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-remaining-import-scratch

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the ready-for-review PR has passed all checks and is ready for review label Aug 15, 2026
@jeffreylouden
jeffreylouden merged commit 0614807 into main Aug 15, 2026
10 checks passed
@jeffreylouden
jeffreylouden deleted the chore/remove-remaining-import-scratch branch August 15, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review PR has passed all checks and is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant