chore: remove remaining import scratch from data/ - #625
Conversation
PR #426 added a .gitignore whitelist so data/ tracks only the five canonical collections, and removed the data/ddmf/merge-pr-body.md leak. Five more slipped past it: PRs #409, #410, #411, #412 and #414 were branched before the guard landed and merged after it, so their already- staged scratch files were unaffected by the new ignore rule. Remove the five stragglers: - data/algorithmix/merge-pr-body.md - data/aly-james-lab/merge-pr-body.md - data/aom/merge-pr-body.md - data/auburn-sounds/merge-pr-body.md - data/black-salt-audio/merge-pr-body.md These are `gh pr create --body-file` inputs, not catalog data. Nothing in the codebase references them and they contain no YAML, so `pnpm validate` is unchanged at 16729 entries. No changeset: the check only fires on `^data/.*\.yaml$`, and #426 set the same precedent. The guard itself is holding — no scratch has been committed to data/ in the ~2 months since these five landed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
WalkthroughFive vendor-specific Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes five stray scratch files from the data directories without altering catalog data or runtime behavior; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR #426 added a
.gitignorewhitelist sodata/tracks only the five canonical collections, and removed thedata/ddmf/merge-pr-body.mdleak. Five more slipped past it.Why the guard missed them
All five landed after #426. PRs #409, #410, #411, #412 and #414 were branched before the guard and merged after it, so their already-staged scratch files were unaffected by the new ignore rule — gitignore has no say over what's already staged.
Changes
Removes the five stragglers:
data/algorithmix/merge-pr-body.mddata/aly-james-lab/merge-pr-body.mddata/aom/merge-pr-body.mddata/auburn-sounds/merge-pr-body.mddata/black-salt-audio/merge-pr-body.mdThese are
gh pr create --body-fileinputs, not catalog data.Verification
merge-pr-bodyoutsidedata/itselfpnpm validateunchanged at 16729 entries, no new warnings.github/workflows/changeset.ymlonly fires on^data/.*\.yaml$, and chore: remove import scratch from data/ and guard against recurrence #426 set the same precedentNote
The guard itself is holding — no scratch has been committed to
data/in the ~2 months since these five landed, and the source workflow was separately fixed to write to the racks scratch dir. This is cleanup of a closed problem, not a live leak.🤖 Generated with Claude Code
Summary by CodeRabbit