fix: unify webhook listeners on path based endpoints - #304
Open
pepordev wants to merge 8 commits into
Open
Conversation
Signed-off-by: Pedro Parra Ortega <parraortega.pedro@gmail.com>
Signed-off-by: Pedro Parra Ortega <parraortega.pedro@gmail.com>
Skarlso
self-requested a review
April 16, 2026 07:20
Skarlso
reviewed
Apr 20, 2026
Skarlso
left a comment
Skarlso
left a comment
Contributor
There was a problem hiding this comment.
Initial round done. I know this is mostly borrowed code. I tried to flag only criticals. Let's leave it off a bit better than we found it. :)
Signed-off-by: Pedro <parraortega.pedro@gmail.com>
Signed-off-by: Pedro Parra Ortega <parraortega.pedro@gmail.com>
Signed-off-by: Pedro Parra Ortega <parraortega.pedro@gmail.com>
Contributor
|
I'll fix the cve thing. |
Contributor
|
Done :) Should be on main. |
Contributor
Author
updated! thanks! |
Contributor
|
will take a look at this today afternoon! Thanks |
Skarlso
reviewed
Jun 26, 2026
Skarlso
left a comment
Skarlso
left a comment
Contributor
There was a problem hiding this comment.
Couple of more issues, but it's getting there! :) Nice! :)
Contributor
|
@pepordev With the config thing out of the way, the rest looks okay expect for the default thing in my last comment. |
Contributor
|
And the otherone with the deadlock. :_ |
Signed-off-by: Pedro Parra Ortega <parraortega.pedro@gmail.com>
…oader into fix/unify-webhook-listeners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #242
I've test it out in our environments with multiples configurations using our keeper-security integration and it is working fine