externpro 26.01.5-7-g64a1663 sync - #9
Merged
Merged
Conversation
Replace backslash-escaped quotes with CMake bracket-quoted strings so the preprocessor define values are passed to the compiler literally. This avoids both editor syntax highlighting issues and build errors from stray backslashes in the compiler flags.
- Update minimum CMake version from 3.31 to 4.3 - Remove XP_NAMESPACE and xproinc.cmake inclusion (now part of CMakePresets) - Package name and Target Namespace now match - Make xpExternPackage conditional 'if(COMMAND' and move to end of CMakeLists.txt - xpExternPackage: infer dependency (Threads), remove FIND_THREADS - Add CMAKE_EXPERIMENTAL_GENERATE_SBOM in presets
Turn on enable_tmate for the Windows job in xpBuild so we can SSH into the runner and debug the Windows linker issues interactively.
Use find_library with the Windows SDK path so the Visual Studio linker receives ws2_32.lib instead of -lws2_32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update externpro submodule to
26.01.5-7-g64a1663Changes
.devcontainerto externpro26.01.5-7-g64a1663bfed68d1a12ffd2b248e405d7cfad18f0ef5327864a1663b4a48cadfbcf0e3e06f699041e38613d8.github/release-tag.json(tag:xpv1.1.1l.5)xprodeps.mdxprodeps.svgWorkflow Update Report
CMakePresets.json
Auto-fix: replaced
.devcontainer/cmake/presets/xpWindowsVs2022.jsoninclude and stagedCMakePresets.jsonCMakePresets.json review needed
This PR was created automatically by GitHub Actions