Skip to content

build: Update tsc and Node#4764

Open
kerams wants to merge 4 commits into
fable-compiler:mainfrom
kerams:x
Open

build: Update tsc and Node#4764
kerams wants to merge 4 commits into
fable-compiler:mainfrom
kerams:x

Conversation

@kerams

@kerams kerams commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Required for #4759

"module": "es2020", /* Specify what module code is generated. */
// "rootDir": "./", /* Specify the root folder within your source files. */
"moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
"moduleResolution": "bundler", /* Specify how TypeScript looks up a file from a given module specifier. */

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node is removed in v7.

@MangelMaxime

Copy link
Copy Markdown
Member

In the past I remember we add discussion with using what ever version of Node came with setup/node actions and allowing users to user whatever version they have on their machine.

However, with #4759 users are going to need to have Temporal available on their machine. Instead of failing during tests execution because Temporal is undefined or something I think it is best to make NPM error with a clearer message.

npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: undefined
npm error notsup Not compatible with your version of node/npm: undefined
npm error notsup Required: {"node":"26"}
npm error notsup Actual:   {"node":"v24.16.0","npm":"11.13.0"}
npm error A complete log of this run can be found in: /home/mmangel/.npm/_logs/2026-07-11T18_51_05_698Z-debug-0.log

This will impact only contributor of JavaScript/TypeScript target as we run npm install only for tasks related to these targets.

@MangelMaxime MangelMaxime requested a review from ncave July 11, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants