Fix compatibility with fmt 12.2.0 - #702
Open
xiaozhuai wants to merge 1 commit into
Open
Conversation
7 tasks
Contributor
|
@createdbysk has imported this pull request. If you are a Meta employee, you can view this in D109469052. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fmtlib/fmt deprecated
<fmt/core.h>in commit 0007426. Starting from fmt 12.2.0, using<fmt/core.h>causes compilation errors because the deprecated include is now opt-in only.Fix
Replace all
#include <fmt/core.h>with#include <fmt/format.h>, which is the standard header in fmt 12.2.0+.