Throw special error if rejected Promises are incorrectly instrumented#36328
Draft
eps1lon wants to merge 1 commit intofacebook:mainfrom
Conversation
github-actions
Bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/04-22-_fiber_throw_special_error_if_rejected_promises_are_incorrectly_instrumented
branch
3 times, most recently
from
ab70052 to
8fc1b9e
Compare
eps1lon
changed the title
eps1lon
force-pushed
the
sebbie/04-22-_fiber_throw_special_error_if_rejected_promises_are_incorrectly_instrumented
branch
from
8fc1b9e to
4c13990
Compare
eps1lon
force-pushed
the
sebbie/04-22-_fiber_throw_special_error_if_rejected_promises_are_incorrectly_instrumented
branch
from
4c13990 to
2ba964a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a rejected
Promiseis instrumented in userspace while setting the rejection reason in the wrong field (e.g.errorinstead ofreason), React will throw undefined (becauseusable.reasondoesn't exist). This makes it incredibly hard to find the actual rejection reason.React is now throwing a generic error if we couldn't find the rejection reason. That will produce a callstack pointing into the problematic Promise from where you can hopefully extract the real rejection reason (alongside fixing the bad instrumentation).
We're doing this in prod since this is unlikely to surface in dev. We're only doing runtime type-checking for the rejected case. That should be hit rarely and therefore hopefully have negligible runtime impact.