Conversation
generateLtr and generateRtl take and return a [key, value] pair, but positionTry mapped only the value, so the returned pair was spliced in as the value and every declaration was emitted twice with an RTL variant for each rule. The generators are now applied to the whole entry with objMapEntry. Snapshots updated to the corrected rules.
|
@lenamonj is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @lenamonj! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
What changed / motivation ?
stylex.positionTryemitted every declaration twice, once with the property name as its own value, and produced an RTL variant for every rule.generateLtrandgenerateRtltake and return a[key, value]pair, but the code mapped only the value, so the returned pair was spliced in as the value:anchor-name:anchor-name;anchor-name:--myAnchor. The generators are now applied to the whole entry withobjMapEntry, the same way the other transforms use them.Linked PR/Issues
None.
Additional Context
The existing snapshots recorded the doubled output; they are updated to the corrected rules and the RTL variant is
nullwhere nothing flips.Pre-flight checklist
Contribution Guidelines