Skip to content

[babel-plugin] Fix positionTry emitting every declaration twice - #1850

Open
lenamonj wants to merge 1 commit into
facebook:mainfrom
lenamonj:position-try-double-emission
Open

lenamonj wants to merge 1 commit into
facebook:mainfrom
lenamonj:position-try-double-emission

Conversation

@lenamonj

@lenamonj lenamonj commented Sep 6, 2026

Copy link
Copy Markdown

What changed / motivation ?

stylex.positionTry emitted every declaration twice, once with the property name as its own value, and produced an RTL variant for every rule. generateLtr and generateRtl take and return a [key, value] pair, but the code mapped only the value, so the returned pair was spliced in as the value: anchor-name:anchor-name;anchor-name:--myAnchor. The generators are now applied to the whole entry with objMapEntry, the same way the other transforms use them.

Linked PR/Issues

None.

Additional Context

The existing snapshots recorded the doubled output; they are updated to the corrected rules and the RTL variant is null where nothing flips.

Pre-flight checklist

generateLtr and generateRtl take and return a [key, value] pair, but positionTry mapped only the value, so the returned pair was spliced in as the value and every declaration was emitted twice with an RTL variant for each rule. The generators are now applied to the whole entry with objMapEntry. Snapshots updated to the corrected rules.
@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

@lenamonj is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla

meta-cla Bot commented Sep 6, 2026

Copy link
Copy Markdown

Hi @lenamonj!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2026
@meta-cla

meta-cla Bot commented Sep 6, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant