Fix SQLAlchemy RemovedIn20Warning and pin SA to 1.4.54 - #836
Closed
ambv wants to merge 1 commit into
Closed
Conversation
Summary: Add `cascade_backrefs=False` to all `relationship` definitions in `fbcode/frl/ae/aepsych/aepsych/database/tables.py` to silence the SQLAlchemy 1.4→2.0 `RemovedIn20Warning` at `db.py:391` (`record.parent = master_table` via `_warn_for_cascade_backrefs`). Pin `SQLAlchemy==1.4.54` in `fbcode/frl/ae/aepsych/setup.py` to match `third-party/pypi/sqlalchemy/VERSION.bzl`. Extend `fbcode/frl/ae/aepsych/aepsych/utils_logging.py` `_IGNORED_WARNINGS` with patterns for `torch.jit.script`, `NCCL_DEBUG`, `pkg_resources`, `_register_pytree_node` to unblock `AEPSYCH_MODE=test`. Add `fbcode/frl/ae/aepsych/tests/test_gha_ci_parity.py` to test GHA CI parity. Differential Revision: D117278778 Signed-off-by: Lukasz Langa <ambv@meta.com>
meta-cla
Bot
added
the
CLA Signed
|
@ambv has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117278778. |
|
This pull request has been merged in 072d4c3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
cascade_backrefs=Falseto allrelationshipdefinitions infbcode/frl/ae/aepsych/aepsych/database/tables.pyto silence the SQLAlchemy 1.4→2.0RemovedIn20Warningatdb.py:391(record.parent = master_tablevia_warn_for_cascade_backrefs).Pin
SQLAlchemy==1.4.54infbcode/frl/ae/aepsych/setup.pyto matchthird-party/pypi/sqlalchemy/VERSION.bzl.Extend
fbcode/frl/ae/aepsych/aepsych/utils_logging.py_IGNORED_WARNINGSwith patterns fortorch.jit.script,NCCL_DEBUG,pkg_resources,_register_pytree_nodeto unblockAEPSYCH_MODE=test.Add
fbcode/frl/ae/aepsych/tests/test_gha_ci_parity.pyto test GHA CI parity.Differential Revision: D117278778