Shared people once per provider, -Tier on AD and Okta, and a step table for New-ADEnvironment - #47
Merged
Merged
Conversation
The Active Directory data logs the eleven people written in other writing systems in under logins of its own, and the four generators mapped those rows across as bulk people beside the core rows that already carried them, so Entra, Authentik, FreeIPA and PingOne each held the same eleven people twice under two logins. The generators now recognise a shared person by name, skip the AD row, and remember it under the shared key so a bulk person managed by one of them still points at them. Each bulk tier is 300 people rather than 311; the counts in the tests, READMEs and help follow.
…from a step table Entra, Authentik, FreeIPA and PingOne already took -Tier Core for the designed people and -Tier Bulk for the generated volume; AD and Okta took nothing, so a script written for one provider failed on the other two. ADUsers.csv carries a Tier column, Core for the eleven people every provider holds and Bulk for the three hundred generated, and New-ADTestUser and New-ADEnvironment take -Tier. A manager left out by the tier is not set rather than looked for and reported missing. OktaUsers.csv carries the column too, every row Core, and New-OktaUser and New-OktaEnvironment accept -Tier so the same call runs everywhere. New-ADTestUser creates on background jobs, which a unit test cannot stand in for, so the row selection and the manager pairs come from Select-ADTestSeedUser, tested against the real data on both editions; the command is held to asking the helper for the tier it was given before any job starts. New-ADEnvironment declares its eight steps as data in dependency order, the way the Entra and Okta orchestrators do, and one loop announces, gates, runs and records each. The ShouldProcess targets, the step results, the error-judged policy and DNS steps, the deny-logon policy after the service accounts and the vault or password file for their passwords are unchanged. A step not attempted because the domain controller stopped answering now says so instead of "skipped as requested".
fadwen
force-pushed
the
feat/data-and-tier
branch
from
September 14, 2026 18:43
d549923 to
e53a33d
Compare
… passes The help gate requires three examples from every exported command and the Compare page shipped with two, which failed the gate on main once #45 merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three smaller things, each its own commit.
Every shared person exists once in every provider
The Active Directory data logs the eleven people written in other writing systems in under logins of its own (
josenforjnino,zoemforzmueller), and the four seed generators mapped those rows across as bulk people beside the core rows that already carried them. Entra, Authentik, FreeIPA and PingOne each held the same eleven people twice under two logins.The generators now recognise a shared person by name, skip the AD row, and remember it under the shared key so a bulk person managed by one of them still points at them. Each bulk tier is 300 people rather than 311: 318 Entra users, 319 Authentik and PingOne users, 346 FreeIPA users. The counts in the tests, the READMEs and the help follow. The AD data keeps its own logins, which is why
Compare-TestEnvironmentmatches it by name.-Tiermeans the same thing on every providerEntra, Authentik, FreeIPA and PingOne already took
-Tier Corefor the designed people and-Tier Bulkfor the generated volume; AD and Okta took nothing, so a script written for one provider failed on the other two.ADUsers.csvcarries aTiercolumn: Core for the eleven people every provider holds, Bulk for the three hundred generated.New-ADTestUserandNew-ADEnvironmenttake-Tier. A manager left out by the tier is not set rather than looked for and reported missing.OktaUsers.csvcarries the column too, every row Core, because eight designed people leave no room for volume.New-OktaUserandNew-OktaEnvironmentaccept-Tierso the same call runs everywhere.New-ADTestUsercreates its users on background jobs, which a unit test cannot stand in for, so the row selection and the manager pairs now come fromSelect-ADTestSeedUser, tested against the real data. The command is held to asking the helper for the tier it was given before any job starts.New-ADEnvironmentruns its steps from a tableThe eight steps were eight copies of the same forty lines. They are now declared as data in dependency order, the way the Entra and Okta orchestrators declare theirs, and one loop announces, gates, runs and records each of them. Nothing observable changed: the same
ShouldProcesstargets, the same step results underOperations, the password policy and DNS steps still judged on the errors they collect, the deny-logon policy still right after the service accounts and only when they succeeded, and the vault or the password file still written for the service accounts. One message did: a step not attempted because the domain controller stopped answering now says so, where it used to say "skipped as requested". Three tests were added for the vault path, the file fallback and that message.Checks
Invoke-Pester ./Tests/Unit: 2,731 passed on PowerShell 7 (one skipped, pre-existing) and 2,732 passed on Windows PowerShell 5.1, none failed. The 5.1 run caught aSort-Object -Stablethat 7 accepts; it is gone.Invoke-ScriptAnalyzer -Recurse -Severity Error, Warning: clean../Build/Build-Help.ps1: rebuilt;Publish-Module.ps1 -WhatIf: passes,Verify/not shipped.