Famedly release/v1.158 - #279
Merged
Merged
Conversation
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
…mbnailer (#18831) Signed-off-by: cat <cat@plan9.rocks>
…pt instructions) (#19968) As discussed in [`#element-backend-internal:matrix.org`](https://matrix.to/#/!SGNQGPGUwtcPBUotTL:matrix.org/$29ZzRe7gg62UZmT0bgeseMs320Kb-Ub6DyaQE20-3ng?via=jki.re&via=element.io&via=matrix.org) Our assumptions on why this was done previously: in the olden days you'd get paged doing the redeploy even if everything was actually fine (probably before we started doing rolling restarts?)
…macOS (#19962) BSD vs GNU `sed` problems: ```shell $ sed -i '0,/^\$id: .*/s||$id: https://element-hq.github.io/synapse/schema/synapse/v1.157/synapse-config.schema.json|' schema/synapse-config.schema.yaml sed: 1: "schema/synapse-config.s ...": bad flag in substitute command: 'h' ```
Conflicts: scripts-dev/release.py
Fix #18530 Complement test changes: matrix-org/complement#858 SyTest changes: matrix-org/sytest#1422
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
…MSC4335 (#18876) This PR uses the new `M_USER_LIMIT_EXCEEDED` common error code instead of the malformed `M_RESOURCE_LIMIT_EXCEEDED` error code (as reported by #18749) (spec: MSC4335). The error code is also changed from `400` to `403` as this matches what is in the spec for the endpoints: https://spec.matrix.org/v1.18/client-server-api/#post_matrixmediav3upload and https://spec.matrix.org/v1.18/client-server-api/#put_matrixmediav3uploadservernamemediaid (albeit the latter says that `M_FORBIDDEN` would be returned) By default a new built-in `media_upload_limit_exceeded.html` template will be served for the `info_uri`. Administrators can specify an external URI in config instead. Compatibility is retained for any existing modules making use the `MediaUploadLimit` (e.g. via the `get_media_upload_limits_for_user` callback).
…19966)
The cache key of `_get_server_keys_json` is a single argument which is
itself a `(server_name, key_id)` tuple, and `store_server_keys_response`
passed that nested tuple straight into the cache invalidation stream.
psycopg2 quietly serialises the inner tuple as a Postgres *record*, so
the `keys` column of `cache_invalidation_stream_by_instance` ended up
holding the record literal as a single string (e.g.
`{"(srv,ed25519:abc)"}`) — which never matches the real cache key on the
receiving side, i.e. the
invalidation has always been a silent no-op on workers. The native Rust
backend's stricter parameter conversion turns the same nested tuple into
a loud `TypeError: unsupported parameter type for postgres: tuple`.
Fix it the same way element-hq/synapse#18899 did
for `_get_e2e_cross_signing_signatures_for_device`, which has the same
nested-tuple key shape: invalidate the local cache directly, JSON-encode
the key for the replication row, and decode it again in
`process_replication_rows`.
Found as part of the the effort to port the database pool to Rust.
This reverts commit befd2e2.
…hutdown (#20009) Use weakref to Python `DatabasePool` to allow homeserver to cleanly shutdown Spawning from [upgrading](element-hq/synapse-small-hosts#420 (comment)) the Synapse version in Synapse Pro for small hosts and seeing our tenant deprovision tests failing (end-to-end Complement tests). Specifically, it was failing with a test in [`TestLogging`](https://github.com/element-hq/synapse-small-hosts/blob/f24ee731ff419890680d1d80ef6eafe44f87f2c2/complement/tests/multi_synapse/logging_test.go#L328-L385) in CI but was equally reproducible with any test where we deprovision (`deployment.StopServer(...)`) like [`TestProvisionHomeserverTenant/deprovision_homeserver_tenant`](https://github.com/element-hq/synapse-small-hosts/blob/f24ee731ff419890680d1d80ef6eafe44f87f2c2/complement/tests/multi_synapse/provision_test.go#L48-L58). Clean homeserver shutdown specifically regressed with the changes from element-hq/synapse#19878. The `PythonDatabasePoolWrapper` in Rust holds onto a reference to the Python `DatabasePool` which references the Python `HomeServer` and keeps the `HomeServer` from being garbage collected on the Python side. This PR updates `PythonDatabasePoolWrapper` to use a weak reference. ### Dev notes Previous PR where we had to deal with Rust <-> Python reference cycles, element-hq/synapse#19837 (comment) PyO3 garbage collector docs (`__traverse__`, `__clear__`): https://pyo3.rs/v0.28.3/class/protocols#garbage-collector-integration ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [x] Pull request is based on the develop branch * [x] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [x] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))
Signed-off-by: dependabot[bot] <support@github.com>
…#19984) This means we can point to a single source of truth instead of duplicating the content to the tag and GitHub release. Less to manage and worry about when you make some updates to the changelog (maintenance burden). We also get to avoid the content sitting in the vendor lock-in GitHub releases. We point to `https://github.com/element-hq/synapse/blob/{repo.active_branch.name}/CHANGES.md` as it will have the relevant changelog entry at the top and won't change as we archive releases on `develop`. Even for RC releases after the main release goes out, the entry will still be towards the top. We could try to get the heading anchor for the specific section but I thought that it wasn't necessary (nice but more complex).
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
…room version mismatch) (#20015) Fix `RemoteJoinHelper` signing events with mismatched room version compared to the `room_version` arg. The default room version on `develop` is `11` but the `RemoteJoinHelper` `room_version` arg defaults to `10` (room version mismatch). This mismatch wasn't present where this fix was developed (element-hq/synapse-private#136) as the default room version was only recently bumped to `11` via element-hq/synapse#18680 (not even in a release yet). Fixes the CI being broken on `develop` ❌: ``` [ERROR] Traceback (most recent call last): File "/home/runner/work/synapse/synapse/tests/federation/test_federation_join_upgraded_room.py", line 298, in test_no_transfer_when_tombstone_does_not_match join_helper.join(local_user_id, local_user_tok) File "/home/runner/work/synapse/synapse/tests/federation/_remote_join.py", line 350, in join self._test_case.helper.join(remote_room_id, local_user_id, tok=local_user_tok) File "/home/runner/work/synapse/synapse/tests/rest/client/utils.py", line 195, in join return self.change_membership( File "/home/runner/work/synapse/synapse/tests/rest/client/utils.py", line 333, in change_membership assert channel.code == expect_code, ( builtins.AssertionError: Expected: 200, got: 400, PUT /_matrix/client/r0/rooms/!remote-room:other.example.com/state/m.room.member/@user1:test?access_token=syt_dXNlcjE_JSEarRndiAGqtydnrdLn_33qlLD -> resp: b'{"errcode":"M_UNKNOWN","error":"No create event in state"}' tests.federation.test_federation_join_upgraded_room.FederationJoinUpgradedRoomTestCase.test_no_transfer_when_tombstone_does_not_match ``` These tests were originally introduced element-hq/synapse-private#136 (developed private as this was part of the Synapse security release) and introduced into the public codebase via element-hq/synapse@cbc6934
…er federation. (#20019) Closes: element-hq/synapse#19904 --------- Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
…tu 26.04 'Resolute Raccoon' (#20039) Fix element-hq/synapse#20031 ### Dev notes - https://endoflife.date/ubuntu - https://endoflife.date/debian - https://endoflife.date/python Finding Python version on distros: - https://packages.debian.org/trixie/python3 - https://packages.ubuntu.com/resolute/python3
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 80.58% 80.73% +0.15%
==========================================
Files 501 503 +2
Lines 72107 72286 +179
Branches 10848 10872 +24
==========================================
+ Hits 58105 58363 +258
+ Misses 10755 10658 -97
- Partials 3247 3265 +18
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
FrenchGithubUser
force-pushed
the
famedly-release/v1.158
branch
from
August 10, 2026 15:32
0ad58b3 to
9d97a90
Compare
FrenchGithubUser
marked this pull request as ready for review
August 10, 2026 16:19
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYN-105