Skip to content

fix: presence getting stuck - #280

Closed
FrenchGithubUser wants to merge 1 commit into
masterfrom
tt/fix-presence-stream
Closed

fix: presence getting stuck#280
FrenchGithubUser wants to merge 1 commit into
masterfrom
tt/fix-presence-stream

Conversation

@FrenchGithubUser

Copy link
Copy Markdown
Member

this has been largely written by claude. it claims to have found the issue, fixed it and tested the fix, but I haven't verified it all. double check things!

this has been largely written by claude. it claims to have found the
issue, fixed it and tested the fix, but I haven't verified it all.
double check things!
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.73%. Comparing base (013821e) to head (2523ecb).

Files with missing lines Patch % Lines
synapse/storage/util/id_generators.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   80.73%   80.73%   -0.01%     
==========================================
  Files         503      503              
  Lines       72286    72296      +10     
  Branches    10872    10873       +1     
==========================================
+ Hits        58363    58371       +8     
- Misses      10658    10659       +1     
- Partials     3265     3266       +1     
Files with missing lines Coverage Δ
synapse/storage/util/id_generators.py 90.72% <90.90%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013821e...2523ecb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrenchGithubUser

Copy link
Copy Markdown
Member Author

closing in favor of the upstream PR: element-hq/synapse#20090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant