Handle fragmented containers in zmq, kafka inputs#194
Open
cmikk wants to merge 1 commit into
Open
Conversation
Properly propagate the `nmsg_res_again` return of _input_nmsg_unpack_container through _input_process_buffer_into_container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a segfault when consuming NMSG container data over kafka.
The function
_input_process_buffer_into_containercan returnnmsg_res_successwith a NULLnmsg, later dereferenced based on thenmsg_res_successreturn value. This PR propagates a non-success return from_input_nmsg_unpack_container,nmsg_res_againin the case of fragmentation.