Conversation
* added small chimera linux logo * Add logo type for Chimera_small --------- Co-authored-by: Weed <weedygmd> Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>
* Logo: add chimera2, parabola2_small, postmarketos2, qubes_small * Logo: add types to chimera2, parabola2_small, postmarketos2, qubes_small, remove "parabola-gnulinux" * Change logo names to use capital letters --------- Co-authored-by: v_v <circlepuller@inbox.lv> Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>
Contributor
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 13 medium 2 high |
| Security | 4 critical |
🟢 Metrics 22 complexity
Metric Results Complexity 22
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
There was a problem hiding this comment.
Pull request overview
Release prep for fastfetch v2.65.3, combining version bumps, changelog updates, logo additions/renames, and a set of platform-specific detection/performance improvements (WSLg parsing, Astra version, Windows PowerShell version, macOS media).
Changes:
- Bump project/versioning metadata to 2.65.3 and update the changelog.
- Add multiple new ASCII logos and adjust several existing logo name mappings.
- Add optional function tracing support and various platform tweaks (WSLg parsing, Astra version formatting, Windows registry-based PowerShell version detection, macOS media optimization).
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/logo/image/image.c | Adjust Chafa dynamic library loading logic (Win/non-Win). |
| src/logo/image/im7.c | Adjust ImageMagick 7 dynamic library loading logic. |
| src/logo/image/im6.c | Reformat ImageMagick 6 library load invocation. |
| src/logo/ascii/q/qubes_small.txt | Add new Qubes small ASCII logo. |
| src/logo/ascii/q.inc | Register Qubes_small logo. |
| src/logo/ascii/p/postmarketos2.txt | Add new PostMarketOS2 ASCII logo. |
| src/logo/ascii/p/parabola2_small.txt | Add new Parabola2_small ASCII logo. |
| src/logo/ascii/p.inc | Adjust Parabola names and register new Parabola2_small/PostMarketOS2 logos. |
| src/logo/ascii/f/flatcar.txt | Add new Flatcar ASCII logo. |
| src/logo/ascii/f.inc | Register Flatcar logo; adjust Filotimo name casing. |
| src/logo/ascii/c/chimera_linux2.txt | Add new Chimera2 ASCII logo. |
| src/logo/ascii/c/chimera_linux_small.txt | Add new Chimera_small ASCII logo. |
| src/logo/ascii/c.inc | Adjust several C* logo names; register Chimera2/Chimera_small; adjust CoreOS/ContainerLinux naming. |
| src/logo/ascii/a/azurelinux2.txt | Add new AzureLinux2 ASCII logo. |
| src/logo/ascii/a/azurelinux.txt | Add new AzureLinux ASCII logo. |
| src/logo/ascii/a.inc | Register AzureLinux/AzureLinux2 logos. |
| src/detection/wm/wm_linux.c | Update WSLg version parsing for newer formats. |
| src/detection/terminalshell/terminalshell.c | Speed up Windows PowerShell version detection via registry. |
| src/detection/os/os_linux.c | Add Astra Linux version formatting. |
| src/detection/media/media_apple.m | Change authorized-process media retrieval mechanism on macOS. |
| src/common/thread.h | Windows header change; add ffThreadGetCurrentId() helpers. |
| src/common/library.h | Refactor FF_LIBRARY_LOAD macro and function declarations. |
| src/common/impl/tracer.c | Add new optional function tracing implementation. |
| src/common/impl/library.c | Split library loader into Single/Multi implementations. |
| src/common/impl/io_windows.c | Adjust Windows read buffer reservation behavior. |
| src/common/impl/FFstrbuf.c | Refactor/relocate some FFstrbuf helpers; add formatted constructors. |
| src/common/impl/FFPlatform_windows.c | Switch Windows architecture detection to SharedUserData. |
| src/common/impl/FFlist.c | Move ffListAdd implementation out of .c (to header). |
| src/common/FFstrbuf.h | Move several FFstrbuf routines inline; add new APIs. |
| src/common/FFlist.h | Inline ffListAdd. |
| debian/changelog.tpl | Add new Debian changelog template entry. |
| CMakeLists.txt | Bump version; add ENABLE_TRACER build option/wiring. |
| CHANGELOG.md | Add 2.65.3 release notes; minor tweak to 2.65.2 text. |
Comment on lines
+124
to
+129
| events[idx].ts = get_time_us(); | ||
| #if _WIN32 | ||
| events[idx].tid = (uint64_t) GetCurrentThreadId(); | ||
| #else | ||
| events[idx].tid = (uint64_t) (uintptr_t) pthread_self(); | ||
| #endif |
Comment on lines
+333
to
+335
| FF_A_UNUSED static void detectAstraVersion(FFOSResult* result) { | ||
| // `PRETTY_NAME` is just `Astra Linux`; the version is in `VERSION_ID`, e.g. `2.12_x86-64` | ||
| ffStrbufAppendSUntilC(&result->version, result->versionID.chars, '_'); |
Comment on lines
+1
to
+5
| fastfetch (2.65.2~#UBUNTU_CODENAME#) #UBUNTU_CODENAME#; urgency=medium | ||
|
|
||
| * Update to 2.65.2 | ||
|
|
||
| -- Carter Li <zhangsongcui@live.cn> Mon, 29 Jun 2026 10:05:47 +0800 |
| // Parabola | ||
| { | ||
| .names = { "parabola", "parabola-gnulinux" }, | ||
| .names = { "Parabola" }, |
| // ParabolaSmall | ||
| { | ||
| .names = { "parabola_small", "parabola-gnulinux_small" }, | ||
| .names = { "Parabola_small", }, |
Comment on lines
398
to
+400
| // ContainerLinux | ||
| { | ||
| .names = { "ContainerLinux", "Container Linux", "Container Linux by CoreOS" }, | ||
| .names = { "CoreOS", "Container Linux by CoreOS" }, |
Comment on lines
+556
to
+560
| #if _WIN32 | ||
| FF_LIBRARY_LOAD(chafa, false, "libchafa-0" FF_LIBRARY_EXTENSION, 0) | ||
| #else | ||
| FF_LIBRARY_LOAD(chafa, false, "libchafa" FF_LIBRARY_EXTENSION, 1) | ||
| #endif |
Comment on lines
+16
to
19
| #if _WIN32 | ||
| FF_LIBRARY_LOAD(imageMagick, FF_LOGO_IMAGE_RESULT_INIT_ERROR, | ||
| "libMagickCore-7.Q16HDRI-10" FF_LIBRARY_EXTENSION, 0 | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist