feat: add refined-github-projects ECC bundle#49
Conversation
…github-projects/SKILL.md)
…github-projects/SKILL.md)
…github-projects/agents/openai.yaml)
…incts/inherited/refined-github-projects-instincts.yaml)
…shell-refactor-or-bugfix.md)
…-ui-enhancement-or-bugfix.md)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor auto review
Found 6 actionable issue(s) on changed lines.
The ECC bundle adds useful scaffolding, but the generated skill docs contain several high-confidence inaccuracies that will mislead agents: the skill body is wrapped in a markdown code fence, slash-command names don't match the committed workflow files, and the framework, ModalShell, and test examples don't match the repository.
Generated automatically when this PR was submitted using Cursor CLI with --model auto.
| @@ -0,0 +1,104 @@ | |||
| ```markdown | |||
There was a problem hiding this comment.
The entire skill is wrapped in a ```markdown fence (closed on line 104), so loaders will treat the instructions as a code block instead of skill content. Remove the outer fence so the file is plain markdown.
|
|
||
| ### Modal Shell Refactor or Bugfix | ||
| **Trigger:** When you need to refactor, consolidate, or fix modal UI logic and behavior. | ||
| **Command:** `/refactor-modal-shell` |
There was a problem hiding this comment.
This references /refactor-modal-shell, but the generated command is /modal-shell-refactor-or-bugfix (see .claude/commands/modal-shell-refactor-or-bugfix.md and ecc-tools.json). Update the command name here and in the Commands table (lines 102–103) or agents will invoke a non-existent slash command.
| ## Coding Conventions | ||
|
|
||
| - **Language:** TypeScript | ||
| - **Framework:** None (vanilla React/TS) |
There was a problem hiding this comment.
The repo is a WXT browser extension using React and @primer/react, not "vanilla React/TS". Document WXT + Primer so agents use the correct build/runtime patterns (pnpm dev, content scripts, Primer theming).
| **Example:** | ||
| ```typescript | ||
| // src/ui/modal-shell.tsx | ||
| export function ModalShell({ isOpen, onClose, children }) { |
There was a problem hiding this comment.
This example API is incorrect: real ModalShell requires ariaLabel (not isOpen) and uses Primer Box/backdrop props, not className="modal-backdrop". Copy the signature from src/ui/modal-shell.tsx to avoid generating invalid modal code.
| - **Test Example:** | ||
| ```typescript | ||
| // src/ui/__tests__/modal-shell.test.tsx | ||
| import { render } from '@testing-library/react' |
There was a problem hiding this comment.
The test example imports @testing-library/react, which is not a project dependency. Match src/ui/__tests__/modal-shell.test.tsx: Vitest plus react-dom/client createRoot, wrapped in Primer ThemeProvider/BaseStyles.
|
|
||
| ## Action | ||
|
|
||
| Use path aliases (@/, ~/) instead of relative imports |
There was a problem hiding this comment.
The repo only uses the @/ path alias (see imports under src/); there are no ~/ imports. Drop ~/ from this instinct so agents don't introduce unsupported alias paths.
Summary
Auto-generated ECC bundle from repository analysis.
What This Does
Merging this PR adds repo-local ECC artifacts for both Claude Code and Codex. The generated bundle captures repository patterns, Codex baseline config, and reusable workflow scaffolds derived from git history analysis.
Analysis Scope
Files
.claude/ecc-tools.json.claude/skills/refined-github-projects/SKILL.md.agents/skills/refined-github-projects/SKILL.md.agents/skills/refined-github-projects/agents/openai.yaml.claude/identity.json.codex/config.toml.codex/AGENTS.md.codex/agents/explorer.toml.codex/agents/reviewer.toml.codex/agents/docs-researcher.toml.claude/homunculus/instincts/inherited/refined-github-projects-instincts.yaml.claude/commands/modal-shell-refactor-or-bugfix.md.claude/commands/sprint-ui-enhancement-or-bugfix.mdOptional: Continuous Learning (25 instincts)
This PR also includes instincts for the continuous-learning-v2 skill. These are optional and only useful if you use that skill.
Import after merging:
Review Checklist
ECC Tools | Everything Claude Code
Summary by cubic
Adds a repo-local ECC bundle that installs Claude Code and Codex skills, workflow commands, and agent configs aligned with this repo’s patterns. Improves repeatability for modal and sprint work and provides a safe Codex MCP baseline.
New Features
.claude/skills/refined-github-projects/SKILL.md,.agents/skills/refined-github-projects/SKILL.md(+openai.yaml).modal-shell-refactor-or-bugfixandsprint-ui-enhancement-or-bugfixin.claude/commands/..codex/config.tomlenablinggithub,@upstash/context7-mcp,exa,@modelcontextprotocol/server-memory,@playwright/mcp, and@modelcontextprotocol/server-sequential-thinking; multi-agent configs (explorer, reviewer, docs-researcher)..claude/identity.jsonand optional continuous-learning instincts at.claude/homunculus/instincts/inherited/refined-github-projects-instincts.yaml..claude/ecc-tools.jsonto manage upgrades and repairs.Migration
/instinct-import .claude/homunculus/instincts/inherited/refined-github-projects-instincts.yaml.~/.codex/config.tomlas noted in.codex/AGENTS.md.Written for commit 069461b. Summary will update on new commits.