Added mirror of displays - #22
Conversation
| outputs_present: [eDP1, DP2] | ||
| outputs_same_as: | ||
| - output: DP2 | ||
| same_as: eDP1 |
There was a problem hiding this comment.
Hm, this rule looks odd. You are trying to configure two displays showing the same content, right? How about we add configure_mirror instead of using configure_row and outputs_same_as? This would simplify the rule a lot:
outputs_present: [eDP1, DP2]
configure_mirror: [eDP1, DP2]There was a problem hiding this comment.
I like the name configure_mirror :) but if I add them to a list (like outputs_present) it would indicate that you could specify more than 2 displays but that is not really possible when mirroring. I can do the change if you still prefer it to be like output_present
There was a problem hiding this comment.
Hm, are you sure that's the case for all graphic cards? I can imagine it's a common limitation (only two outputs in mirror mode), but I guess there are devices where three is also possible.
I'd prefer configure_mirror, you can then remove the code for outputs_same_as, which makes the configuration simpler :)
There was a problem hiding this comment.
I'll have a look at it later and do a fix :)
There was a problem hiding this comment.
Fixed and I rebased it the newly added features
|
Sorry for bumping, is there a way to mirror the screens on currently released version, or should I use this MR? |
|
I would also appreciate this feature |
4 participants
Small patch for creating mirror of displays