Add support for rate - #30
Open
jonaz wants to merge 3 commits into
Open
Conversation
Author
|
Retry does not work. |
Author
|
Can confirm the retry stuff works now like a charm. |
Owner
|
Would you mind rebasing on the master branch? There's a merge conflict |
Also fixed a few other things: - bugs in active mode detection with my display (144hz and 60hz) - Turn off changed displays in a smarter way. Im using usb-c daisychain and had trouble with the current approach. it disabled my screen as soon as the screen went into hibernate because xrandr stopped detecting the display. - some autoformatting of comments and code according to efficient go guidelines - if xrand (ApplyRule) fails, try 3 times with a little more sleep each time. This also solved issues with my daisychained displays. Fixes fd0#29
Author
|
@fd0 rebased on master! |
Author
|
Hmm I personally dont think thats a problem. But to satisfy the linter i could make it public? ping @fd0 |
Author
|
Ping @fd0 ? |
Author
|
ping @fd0 |
displays Happens for example in daisy chaining usb-c to DP it always changes the number when reconnecting to the display
|
Hi @jonaz , are you still using this patch? May I apply it locally since it's not merged? |
Author
|
Yes I use it everyday
…On Sat, 12 Apr 2025, 13:11 Valeriy Litkovskyy, ***@***.***> wrote:
Hi @jonaz <https://github.com/jonaz> , are you still using this patch?
May I apply it locally since it's not merged?
—
Reply to this email directly, view it on GitHub
<#30 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIX4FITP3IJP6DEU3OS7ZL2ZDYGLAVCNFSM6AAAAAB2Y7MFQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJYG44DSMZRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*xFA25E* left a comment (fd0/grobi#30)
<#30 (comment)>
Hi @jonaz <https://github.com/jonaz> , are you still using this patch?
May I apply it locally since it's not merged?
—
Reply to this email directly, view it on GitHub
<#30 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIX4FITP3IJP6DEU3OS7ZL2ZDYGLAVCNFSM6AAAAAB2Y7MFQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJYG44DSMZRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Any change to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed a few other things:
and had trouble with the current approach. it disabled my screen as soon
as the screen went into hibernate because xrandr stopped detecting the
display.
guidelines
time. This also solved issues with my daisychained displays.
Fixes #29