Skip to content

fix: always link header logo to the landing page#930

Open
Gaic4o wants to merge 1 commit into
feature-sliced:mainfrom
Gaic4o:landing
Open

fix: always link header logo to the landing page#930
Gaic4o wants to merge 1 commit into
feature-sliced:mainfrom
Gaic4o:landing

Conversation

@Gaic4o

@Gaic4o Gaic4o commented Jun 10, 2026

Copy link
Copy Markdown
Member

Background

On translated pages such as /kr/ and /ja/ clicking the header logo navigated to the locale-specific get-started page instead of the landing page. This happened because Starlight links the logo to the current locale home by default, and the locale home redirects to get-started. This overrides the SiteTitle component so the header logo always links to the landing page, while keeping the existing redirects unchanged.

2026-06-11.12.41.30.mov

@Gaic4o Gaic4o requested review from Solant and illright June 10, 2026 15:42
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
pr-fsd ✅ Ready (View Log) Visit Preview 14b79f2

@Solant

Solant commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

I have a concern that navigation to the landing page resets the current locale to English

Maybe it is better to implement localized landing pages? In this case we won't have to override the SiteTitle component, and locale will be properly preserved.

@Gaic4o Gaic4o changed the title fix: always link header logo to the English landing page fix: always link header logo to the landing page Jun 12, 2026
@Gaic4o

Gaic4o commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

I have a concern that navigation to the landing page resets the current locale to English

Maybe it is better to implement localized landing pages? In this case we won't have to override the SiteTitle component, and locale will be properly preserved.

This approach makes it much clearer what each item is actually referring to, even with the multi-language setup. It's also a nice way for others to contribute in their own languages.
I'll go ahead and rework it to follow this flow. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants