Skip to content

Support icons - #322

Open
smjyt69 wants to merge 5 commits into
fencer-so:mainfrom
smjyt69:icons
Open

Support icons#322
smjyt69 wants to merge 5 commits into
fencer-so:mainfrom
smjyt69:icons

Conversation

@smjyt69

@smjyt69 smjyt69 commented Jul 31, 2026

Copy link
Copy Markdown

Adds support for goal icons on the frontend.

Changes:

  • Added an optional icon field to the Goal type
  • Wired the existing EmojiPicker, AddIconButton, and GoalIcon components into GoalManager:
    • Tracks the current icon in local state, synced with the selected goal
    • Shows "Add icon" when a goal has no icon, and the icon itself (clickable to change) when it does
    • Picking an emoji updates local state, Redux, and saves it to the backend via a PUT request
  • Displays the goal's icon on GoalCard

@gitguardian

gitguardian Bot commented Jul 31, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials a401171 CommBank-Server/Secrets.json View secret
- - MongoDB Credentials 41ead19 CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant