Skip to content

chore(deps): bump vite-plus to v0.2.2 - #10

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-0.2.2
Draft

chore(deps): bump vite-plus to v0.2.2#10
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-0.2.2

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to the pkg.pr.new prerelease build for v0.2.2 (registry-bridge commit build) to smoke-test the prerelease.

  • vite-plus + vite (alias to @voidzero-dev/vite-plus-core) and vitest pinned to the commit build across deps / overrides / catalogs
  • minimumReleaseAge enabled with the vite-plus / @voidzero-dev/* / oxc / oxlint stack excluded
  • .npmrc (or .yarnrc.yml) points the package manager at the registry bridge (prerelease scaffolding)

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this Jul 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a pnpm-workspace.yaml file to configure a pnpm workspace, migrating several dependencies to use pnpm catalogs and setting up a registry bridge in .npmrc. The review feedback highlights two important issues: first, the minimumReleaseAge is set to 60 minutes, which is likely too short to provide effective protection against supply chain attacks; second, native bundlers like esbuild and rolldown need to be explicitly added to allowBuilds to prevent installation failures under pnpm 10/11's strict build rules.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pnpm-workspace.yaml
Comment on lines +25 to +27
allowBuilds:
edgedriver: true
geckodriver: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Since vite-plus relies on esbuild and rolldown under the hood, and both of these native bundlers use postinstall scripts to fetch their platform-specific binaries, they must be explicitly allowed in allowBuilds.

With strictDepBuilds enabled by default in pnpm 10/11, omitting them will cause the installation to fail or prevent the native binaries from being fetched, breaking the development and build workflows.

allowBuilds:
  edgedriver: true
  geckodriver: true
  esbuild: true
  rolldown: true

Comment thread pnpm-workspace.yaml
@@ -0,0 +1,34 @@
minimumReleaseAge: 60

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The minimumReleaseAge setting in pnpm is configured in minutes, not days or hours. Setting it to 60 means a cooldown of only 1 hour, which is typically too short to effectively protect against supply chain attacks (as malicious packages often take several hours or days to be detected and yanked).

If the intention was to set a longer quarantine period, consider using:

  • 1440 for 1 day
  • 4320 for 3 days
  • 10080 for 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant