Skip to content

revert(docs): remove settings.embedding.allowed-origins from docs.yml (#17773) - #17801

Open
willkendall01 wants to merge 4 commits into
mainfrom
devin/1790000617-revert-embedding-allowed-origins
Open

willkendall01 wants to merge 4 commits into
mainfrom
devin/1790000617-revert-embedding-allowed-origins

Conversation

@willkendall01

@willkendall01 willkendall01 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

Reverts #17773 (settings.embedding.allowed-origins in docs.yml), requested by @willkendall01.

Changes Made

  • git revert of ab03363 — removes EmbeddingConfig from the docs.yml definition, generated schemas/types, ParsedDocsSettingsConfig, DocsDefinitionResolver/ledger passthrough, the valid-embedding-origins validator rule, and associated tests.
  • The already-released changes/5.129.0/add-docs-embedding-allowed-origins.yml entry is left in place (release history); a new changes/unreleased/revert-docs-embedding-allowed-origins.yml (fix) records the revert.
  • Updated README.md generator (N/A)

Testing

  • Affected packages compile (turbo compile for configuration, configuration-loader, docs-validator, docs-resolver, remote-workspace-runner: 49/49)
  • Manual testing (N/A — pure revert)

Link to Devin session: https://app.devin.ai/sessions/5852f54aac7e4702ba83e25ad2baec01
Open in Devin Desktop: https://app.devin.ai/desktop/session/5852f54aac7e4702ba83e25ad2baec01?variant=devin


Devin Review

willkendall01 and others added 2 commits September 21, 2026 14:23
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

nitpickybot[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot changed the title revert: remove settings.embedding.allowed-origins from docs.yml (#17773) revert(docs): remove settings.embedding.allowed-origins from docs.yml (#17773) Sep 21, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Docs Generation Benchmark Results

Comparing PR branch against median of 5 nightly run(s) on main (latest: 2026-09-21T04:06:43Z).

Fixture main PR Delta
docs 210.7s (n=5) 310.9s (35 versions) +100.2s (+47.6%)

Docs generation runs fern generate --docs --preview end-to-end against the benchmark fixture with 35 API versions (each version: markdown processing + OpenAPI-to-IR + FDR upload).
Delta is computed against the nightly baseline on main.
Baseline from nightly run(s) on main (latest: 2026-09-21T04:06:43Z). Trigger benchmark-baseline to refresh.
Last updated: 2026-09-21 15:31 UTC

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

SDK Generation Benchmark Results

Comparing PR branch against median of 5 nightly run(s) on main (latest: 2026-09-21T04:06:43Z).

Full benchmark table (click to expand)
Generator Spec main (generator) main (E2E) PR (generator) Delta
csharp-sdk square 67s (n=5) 98s (n=5) 66s -1s (-1.5%)
go-sdk square 113s (n=5) 235s (n=5) 138s +25s (+22.1%)
java-sdk square 189s (n=5) 256s (n=5) 213s +24s (+12.7%)
php-sdk square 59s (n=5) N/A 46s -13s (-22.0%)
python-sdk square 131s (n=5) 234s (n=5) 132s +1s (+0.8%)
ruby-sdk-v2 square 78s (n=5) 117s (n=5) 62s -16s (-20.5%)
rust-sdk square 140s (n=5) 177s (n=5) 158s +18s (+12.9%)
swift-sdk square 51s (n=5) 342s (n=5) 50s -1s (-2.0%)
ts-sdk square 136s (n=5) 138s (n=5) 103s -33s (-24.3%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-09-21T04:06:43Z). Trigger benchmark-baseline to refresh.
Last updated: 2026-09-21 15:30 UTC

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant