Conversation
Compile rand operands in scalar context so array dereferences like rand @$array produce the array length instead of a RuntimeArray value. Also scalarize the RAND opcode input defensively for eval-generated interpreter bytecode. Add regression coverage for eval-generated rand array dereferences, matching the Randomize failure path. Generated with Codex (https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
randoperands in scalar context sorand @$array_refuses the array lengthTests
maketimeout 60 ./jperl src/test/resources/unit/rand_scalar_context.ttimeout 600 ./jcpan -t RandomizeNote: Randomize still prints legacy
not ok 46-50lines from raw Data::Dumper hash-key ordering comparisons, but its CPANmake testexits OK. Native Perl shows the same brittle ordering issue.