Only supervise tests that require XML generation - #22
Merged
Conversation
alexeagle
marked this pull request as ready for review
August 21, 2026 19:06
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 4ccd1df. Configure here.
| String.format( | ||
| "; add '%s' to the test target's tags attribute", | ||
| ExecutionRequirements.REQUIRES_TEST_XML_GENERATION); | ||
| } |
There was a problem hiding this comment.
Misleading missing-XML tag hint
Low Severity
In workaround mode, the missing-XML failure always appends a hint to add requires-test-xml-generation, even when that tag is already present. Tagged tests that still lack XML (for example on unsupported platforms where ensure_xml is omitted) get an incorrect remediation hint.
Reviewed by Cursor Bugbot for commit 4ccd1df. Configure here.
Author
|
Landing without review so I can get a production build started |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
requires-test-xml-generationtag (analogous torequires-network)ensure_xmlsupervisor to test action inputs only when the target carries that tag and--experimental_test_xml_missing_behavior=workaroundis enabledThis keeps the supervisor out of unrelated test action inputs, avoiding wasted input bytes and broad cache invalidation when the supervisor changes.
Testing