Skip to content

Only supervise tests that require XML generation - #22

Merged
alexeagle merged 2 commits into
8.8.0-figmafrom
codex/requires-test-xml-generation
Aug 21, 2026
Merged

Only supervise tests that require XML generation#22
alexeagle merged 2 commits into
8.8.0-figmafrom
codex/requires-test-xml-generation

Conversation

@alexeagle

@alexeagle alexeagle commented Aug 21, 2026

Copy link
Copy Markdown

Summary

  • add the well-known requires-test-xml-generation tag (analogous to requires-network)
  • add the ensure_xml supervisor to test action inputs only when the target carries that tag and --experimental_test_xml_missing_behavior=workaround is enabled
  • document the same-spawn XML fallback behavior and cover tagged and untagged actions

This keeps the supervisor out of unrelated test action inputs, avoiding wasted input bytes and broad cache invalidation when the supervisor changes.

Testing

bazel test //src/test/java/com/google/devtools/build/lib/analysis:AnalysisTests //src/test/java/com/google/devtools/build/lib/exec:ExecTests '--test_filter=TestActionBuilderTest|StandaloneTestStrategyTest'

@alexeagle
alexeagle marked this pull request as ready for review August 21, 2026 19:06

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 4ccd1df. Configure here.

String.format(
"; add '%s' to the test target's tags attribute",
ExecutionRequirements.REQUIRES_TEST_XML_GENERATION);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misleading missing-XML tag hint

Low Severity

In workaround mode, the missing-XML failure always appends a hint to add requires-test-xml-generation, even when that tag is already present. Tagged tests that still lack XML (for example on unsupported platforms where ensure_xml is omitted) get an incorrect remediation hint.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4ccd1df. Configure here.

@alexeagle

Copy link
Copy Markdown
Author

Landing without review so I can get a production build started

@alexeagle
alexeagle merged commit b100643 into 8.8.0-figma Aug 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant