Repository navigation
Fix library search parsing and source fallback failures - #167
Merged
Merged
Conversation
Preserve partial source failures, surface retryable outage states, share hybrid vectors, and cover search regressions.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
filiksyos
marked this pull request as ready for review
October 6, 2026 13:35
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pnpm test:library).tsc --noEmitand changed-file ESLint passed.next buildpassed using no external service credentials.pnpm lintstill reports the existinglib/use-partner-preview.ts:13set-state-in-effect error and two existing accessibility warnings incomponents/reverse-prompt-home.tsx.Provider configuration
The existing Azure embedding deployment failure and OpenAI fallback
invalid_api_keyare external configuration issues. No credentials, provider settings or database schema were changed. Keyword search now survives those failures.Preview verification completed
64710167858ea4fadc7e335794730627cf161b73.library-searchpassed all 21 regressions, TypeScript and focused ESLint: https://github.com/filiksyos/gitreverse/actions/runs/37471526409accounting,returns 200 and keyword results despite the provider credential failure.Production verification
f464745e7c104996c02690fc37d5dd248ae1fda2; production deploymentdpl_9DkhoGmcQ2HoW2sgcJSKHvA7eos6is READY and attached to gitreverse.com.accounting,search returned 200, 24 rows and total 4,814 through keyword fallback.Follow-up performance diagnosis (read-only)
Catalog inspection and EXPLAIN show the existing
idx_prompt_cache_search_vectorGIN index is used for the full-text count, but the sorted LIMIT 24 row query chooses the cached-at index and filters vectors row by row. An ID-first MATERIALIZED matching CTE instead plans GIN bitmap scan → matched-ID sort → 24 primary-key lookups. The narrow follow-up is a SECURITY INVOKER keyword-search RPC preserving filters, ordering and RLS, plus explicit database migration rollout. No database change, EXPLAIN ANALYZE or measured performance claim was made in this PR.