Skip to content

Fix 3D comparison plots and exercise headless rendering - #46

Merged
soodoku merged 1 commit into
mainfrom
sweep2-pyppur-visualization
Oct 21, 2026
Merged

soodoku merged 1 commit into
mainfrom
sweep2-pyppur-visualization

Conversation

@soodoku

@soodoku soodoku commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Comparison plots with 3D embeddings raised ValueError because their subplots were created as 2D axes. Select the matching projection when constructing the comparison figure.

Replace three empty skipped visualization tests with four real Agg rendering cases covering 2D/3D and labeled/unlabeled embeddings. The 3D cases failed before the fix; all 66 tests now pass with 89% coverage. Ruff, Pyright, docstring lint, and preen pass locally.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-21T06:22:26.659836Z c1e7b88 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@soodoku
soodoku merged commit 2bb23e5 into main Oct 21, 2026
13 checks passed
@soodoku
soodoku deleted the sweep2-pyppur-visualization branch October 21, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant