Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1730 +/- ##
=======================================
Coverage 86.10% 86.10%
=======================================
Files 101 101
Lines 5577 5577
Branches 996 996
=======================================
Hits 4802 4802
Misses 525 525
Partials 250 250 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kriswest
approved these changes
Sep 15, 2026
kriswest
left a comment
Contributor
There was a problem hiding this comment.
LGTM, although co-pilot had a few suggestions you could apply:
- Check version tag doesn't already exist
if git rev-parse "v$VERSION" >/dev/null 2>&1; then echo "::error::Version v$VERSION already exists" exit 1 fi
- Verify files actually changed
git diff --quiet && { echo "::error::No version changes detected" exit 1 }
- Validate lockfile integrity
npm install --package-lock-only git diff --exit-codeFor a FINOS/open-source release process, I'd consider the "version tag already exists" check the most important omission because it prevents accidentally generating a PR for a version that's already been released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolves #
Checklist
General
Documentation
Configuration
config.schema.json) was modified:npm run generate-config-types)npm run gen-schema-doc)Tests
npm test)npm run lintandnpm run format:check)npm run check-types)