-
-
Notifications
You must be signed in to change notification settings - Fork 22
feat: redesign 404 page with error image and fix GitHub Pages routing #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8f9d42b
feat: redesign 404 page with error image and fix GitHub Pages 404 rou…
lenderom da30879
Merge branch 'main' into feat/404-page
MoritzWeber0 519b808
Merge branch 'main' into feat/404-page
therobrob d0eea8f
fix: improve 404 page
lenderom 67eb077
fix: remove float
lenderom c6f0ecb
Merge remote-tracking branch 'origin/main' into feat/404-page
lenderom 0d90fd4
Merge branch 'main' into feat/404-page
lenderom 7d07345
fix: final 404 changes
lenderom bed0457
Merge branch 'feat/404-page' of github.com:fipguide/fipguide.github.i…
lenderom 09751fd
fix: adjust margin for 404 page image in responsive layout
lenderom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| .o-error { | ||
| background-color: var(--bg-default); | ||
| border-radius: var(--border-radius-l); | ||
| border: var(--border); | ||
| padding: 2rem; | ||
|
|
||
| &__body { | ||
| @media (min-width: #{$breakpoint-lg}) { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 3rem; | ||
| } | ||
| } | ||
|
|
||
| &__image { | ||
| margin-bottom: 2rem; | ||
|
|
||
| @media (min-width: #{$breakpoint-lg}) { | ||
| margin-bottom: 0; | ||
| flex: 0 0 40%; | ||
| } | ||
| } | ||
|
|
||
| &__divider { | ||
| @media (min-width: #{$breakpoint-lg}) { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
||
| &__content { | ||
| @media (min-width: #{$breakpoint-lg}) { | ||
| flex: 1; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,3 +25,4 @@ | |
| @import "teamMember.scss"; | ||
| @import "dialog.scss"; | ||
| @import "fip-validity.scss"; | ||
| @import "404.scss"; | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| {{ define "main" }} | ||
| <article class="o-error" data-pagefind-ignore="all"> | ||
| <h1>{{ .Title }}</h1> | ||
| <div class="o-error__body"> | ||
| <div class="o-error__image"> | ||
| {{- $image := .Resources.GetMatch "404.webp" -}} | ||
| {{- partial "image" | ||
| (dict | ||
| "image" $image | ||
| "width" "100%" | ||
| "Page" . | ||
| ) | ||
| -}} | ||
| </div> | ||
| <div class="o-error__content"> | ||
| {{ .Content }} | ||
| </div> | ||
| </div> | ||
| </article> | ||
| {{ end }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.