refactor: Render booking pages in operator context#856
Open
MoritzWeber0 wants to merge 30 commits intomainfrom
Open
refactor: Render booking pages in operator context#856MoritzWeber0 wants to merge 30 commits intomainfrom
MoritzWeber0 wants to merge 30 commits intomainfrom
Conversation
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
07854df to
f826006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a huge one. It completely changes the rendering logic of booking pages. Instead of displaying the rendered version of the booking page on the operator page, we do now render it on demand in the operator page context. With some additional changes in this PR, this will fix many issues:
Issue description
So far, we only hide some booking sections using
display: nonein the CSS of booking expanders. The issue is: Even if hidden, the content is still indexed for the search.This PR changes the approach to no longer render the irrelevant sections to the DOM by storing the rendered sections in the page store.
Steps to reproduce the search issue:
Resolves #887
Resolves #462