Skip to content

Standardize bus handling and add unknown FIP acceptance status#859

Open
lenderom wants to merge 9 commits intomainfrom
feature/bus-standardization-and-unknown-tag
Open

Standardize bus handling and add unknown FIP acceptance status#859
lenderom wants to merge 9 commits intomainfrom
feature/bus-standardization-and-unknown-tag

Conversation

@lenderom
Copy link
Copy Markdown
Member

@lenderom lenderom commented Apr 19, 2026 •
edited
Loading

Summary

  • standardize bus-related train-category IDs across operators
  • align rail replacement bus wording in DE/EN/FR pages
  • move/add rail replacement notes in special tariff conditions where needed
  • add support for fip_accepted=unknown in train-category tags
  • add i18n labels for unknown acceptance status (de/en/fr)
  • update Consistency for break of journes and order of special tariff conditions

Notes

  • includes content and template updates related to bus and rail replacement guidance

Fixes #752

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 19, 2026 •
edited
Loading

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit a768a2c
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/69f611e9598d6b0008f7b83c
😎 Deploy Preview https://deploy-preview-859--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@lenderom lenderom mentioned this pull request Apr 19, 2026
Closed
MoritzWeber0
MoritzWeber0 requested changes Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some findings, hope I didn't miss anything.

Comment thread content/generalinformation/_index.de.md Outdated
Comment thread content/operator/cie/index.en.md
Comment thread content/operator/kml/index.de.md Outdated
Comment thread content/operator/kw/index.en.md Outdated
Comment thread content/operator/sncf/index.de.md Outdated
Comment thread i18n/de.yaml Outdated
@lenderom lenderom requested review from MoritzWeber0 and therobrob May 2, 2026 11:14
therobrob
therobrob reviewed May 2, 2026
View reviewed changes
Comment thread content/operator/cd/index.de.md

Auf anderen Busverbindungen gelten keine FIP Ermäßigungen.

Ein Ticket (Reservierung verpflichtend) muss spätestens 15 Minuten vor Abfahrt an einem ČD Ticketschalter, Fahrkartenautomaten (kein FIP verfügbar) oder im ČD-eShop (kein FIP verfügbar) gekauft werden.
Copy link
Copy Markdown
Member

@therobrob therobrob May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das verwirrt mich: FIP Vergünstigungen gelten nicht im Bus, warum steht bei CD-Ticketschalter nicht "(kein FIP verfügbar)"?

Copy link
Copy Markdown
Member Author

@lenderom lenderom May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja das ist irgendwie doof geschrieben. Was wir sagen wollen:

FIP gilt nicht in Bussen der CD außer SEV und diesem Airport Bus (Reservierungspflicht).
Tickets müssen für diesen Bus vorher gekauft werden. Tickets gibt online, am Schalter und Fahrkartenautomat. FIP Rabatt gibt es aber nur über den Schalter.

Copy link
Copy Markdown
Member

@MoritzWeber0 MoritzWeber0 May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finde die Formulierung auch verwirrend, mein Vorschlag wäre:

Ein Ticket (Reservierung verpflichtend) muss spätestens 15 Minuten vor Abfahrt an einem ČD Ticketschalter gekauft werden. FIP ermäßigte Tickets sind leider nicht an Fahrkartenautomaten oder im ČD-eShop erhältlich.

Comment thread content/operator/kml/index.de.md Outdated
Comment thread content/operator/ks/index.en.md
Comment on lines +38 to +46
{{% train-category
id="bus"
title="Bus"
type="bus"
fip_accepted=false
%}}
FIP tickets are generally not valid on KŚ buses. On rail replacement buses, FIP discounts apply when they replace a train on which FIP would have been valid.
{{% /train-category %}}

Copy link
Copy Markdown
Member

@therobrob therobrob May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum gibt es diesen train-category Expander nicht auf der deutschen Seite? Gilt hier nicht das gleiche, was du bei KML geschrieben hast?

Copy link
Copy Markdown
Member Author

@lenderom lenderom May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du hast Recht. Da hat die KI Mist gebaut. Hier sollte im englischen und französischen kein Expander sein.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@therobrob therobrob therobrob left review comments

@MoritzWeber0 MoritzWeber0 Awaiting requested review from MoritzWeber0

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bus Category

3 participants

@lenderom @MoritzWeber0 @therobrob