Skip to content

cleanup(sessions): replace promises with swift concurrency - #16548

Draft
ncooke3 wants to merge 3 commits into
mainfrom
nc.sessions.async
Draft

cleanup(sessions): replace promises with swift concurrency#16548
ncooke3 wants to merge 3 commits into
mainfrom
nc.sessions.async

Conversation

@ncooke3

@ncooke3 ncooke3 commented Aug 23, 2026

Copy link
Copy Markdown
Member

Note: This is non-breaking, but planned for Firebase 13.0 to prevent risk of introducing a regression in a final 12.x release.

Summary

Replaces the Promises library dependency in FirebaseSessions with native Swift Concurrency.

Key Changes

  • Actor State Management: Replaced FBLPromises subscriber tracking in FirebaseSessions with a new internal SessionsState actor.
  • Dependency Removal: Removed Promises from Package.swift and FirebaseSessions.podspec.
  • Test Modernization: Updated FirebaseSessions unit test suite and base helpers to use async/await and added SessionsStateTests.

#no-changelog

@ncooke3 ncooke3 added this to the Firebase 13 milestone Aug 23, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@ncooke3 ncooke3 self-assigned this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant