fix(functions): avoid recreating a deleted task queue on functions:delete

[kyungseopk1m]

Fixes #9305

firebase functions:delete fails for a Gen 2 onTaskDispatched function when its Cloud Tasks queue has already been deleted out of band:

...queues/myTaskFunction?updateMask=name%2Cstate had HTTP Error: 400,
The queue cannot be created because a queue with this name existed too recently.

Root cause

On delete, Fabricator.disableTaskQueue calls cloudtasks.updateQueue, which issues a queues.patch. Per the Cloud Tasks API, queues.patch is create-or-update, so patching a queue that no longer exists tries to (re)create it — failing with the 400 above when it was deleted too recently, or otherwise silently resurrecting a queue the user intentionally removed.

upsertQueue already guards this exact case with a getQueue 404 check; the disable path did not.

Fix

Add a getQueue existence check before the patch (mirroring upsertQueue): if the queue is already gone (404) the update is skipped; any other error is rethrown.

Note (out of scope)

queues.patch cannot actually change state (it is output only — state changes go through pause/resume or queue.yaml), so the pre-existing { state: "DISABLED" } patch is best-effort and is preserved here unchanged. Making delete truly stop dispatch (via queues.pause) would also require teaching upsertQueue to resume/purge paused queues on redeploy, which looks like a separate change — happy to follow up if you'd prefer that direction.

Notes

• The delete path now also requires the cloudtasks.queues.get permission.
• Tests cover an existing queue (patch preserved), an already-deleted queue (no-op), and non-404 errors (rethrown).

[gemini-code-assist]

Code Review

This pull request resolves issue #9305 by preventing functions:delete from recreating an already-deleted Cloud Tasks queue. It introduces a new disableQueue helper in src/gcp/cloudtasks.ts that safely checks for the queue's existence before attempting to disable it, and updates the Fabricator and associated tests accordingly. Feedback on these changes includes a recommendation to avoid using any for the caught error in disableQueue to adhere to the repository's TypeScript style guide, as well as a suggestion to use idiomatic chai-as-promised assertions in the unit tests instead of manual try-catch blocks.

[kyungseopk1m]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new disableQueue helper in cloudtasks.ts to check if a Cloud Tasks queue exists before attempting to disable it, preventing functions:delete from accidentally recreating an already-deleted queue (fixing issue #9305). The reviewer feedback suggests avoiding the use of any when catching errors in disableQueue to comply with the repository's style guide, recommending a more specific type cast instead.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@1febb29). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10685   +/-   ##
=======================================
  Coverage        ?   61.11%           
=======================================
  Files           ?      653           
  Lines           ?    44006           
  Branches        ?     9056           
=======================================
  Hits            ?    26895           
  Misses          ?    14856           
  Partials        ?     2255           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[andersonaddo]

Heyo! Just popping in - is there a reason this hasn't been merged in yet? @IzaakGough @kyungseopk1m