Conversation
…ter from functionsEmulatorShared (b/568084058)
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up unused imports, interfaces, classes, and helper functions from src/emulator/functionsEmulatorShared.ts. Specifically, it removes the lodash, express, and CloudFunction imports, the EmulatedTriggerMap and FunctionsRuntimeArgs interfaces, the EmulatedTrigger class, and the getEmulatedTriggersFromDefinitions and waitForBody helper functions. There are no review comments, and I have no additional feedback to provide.
nownow95
approved these changes
Sep 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Buganizer b/568084058
Proposed Improvement
Removes dead cluster of legacy in-process function discovery and execution helpers from
src/emulator/functionsEmulatorShared.ts:getEmulatedTriggersFromDefinitions: Unused legacy helper with zero callers across the codebase.class EmulatedTrigger: Only instantiated bygetEmulatedTriggersFromDefinitions, transitively dead.interface EmulatedTriggerMap: Only used as return type ofgetEmulatedTriggersFromDefinitions, transitively dead.interface FunctionsRuntimeArgs: Zero references across the codebase.waitForBody: Unused helper with zero callers across the codebase.lodash,express,CloudFunctionfromfirebase-functions, andInvokeRuntimeOptsfrom./functionsEmulator.This removes 74 lines of unreachable code and cleans up unnecessary dependencies loaded when the functions emulator starts.
Verification
npm run build: Built cleanly.npm run lint:quiet: Passed with no errors or unused import warnings.npm run test:compile: Full type-check passed cleanly.npx mocha 'src/emulator/functions*.spec.ts': All 50 tests passed.